Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review: git mail not sending review to golang-codereviews #11300

Closed
andybons opened this issue Jun 19, 2015 · 4 comments
Closed

x/review: git mail not sending review to golang-codereviews #11300

andybons opened this issue Jun 19, 2015 · 4 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@andybons
Copy link
Member

Using git mail to send out a change, it never reached golang-codereviews@googlegroups.com but the change was created in gerrit.

$ git mail -r nigeltao@golang.org -cc dvyukov@google.com
remote: Processing changes: new: 1, done    
remote: (W) 17536d4: commit subject >65 characters; use shorter first paragraph
remote: (W) 17536d4: too many commit message lines longer than 70 characters; manually wrap lines
remote: 
remote: New Changes:
remote:   https://go-review.googlesource.com/11256 image/gif: set default loop count to 0 when application extension is not present
remote:
@rakyll rakyll added this to the Unreleased milestone Jun 19, 2015
@josharian
Copy link
Contributor

I believe that there is a moderation delay for the first mail by any given contributor; that might be what is going on here.

@andybons
Copy link
Member Author

Gotcha. Thanks for the info.
On Fri, Jun 19, 2015 at 3:00 PM Josh Bleecher Snyder <
notifications@github.com> wrote:

I believe that there is a moderation delay for the first mail by any given
contributor; that might be what is going on here.

—
Reply to this email directly or view it on GitHub
#11300 (comment).

@andybons
Copy link
Member Author

Yep see it now. Closing.

@ianlancetaylor
Copy link
Contributor

I wish we didn't need that moderation delay, but without it a rather annoying number of spam postings get through. In general it should only apply to the first CL you send out.

josharian added a commit that referenced this issue Jun 19, 2015
@josharian
doc: mention moderation delay in contributing docs
5ac5a98 
This sometime worries new contributors.
Hopefully mentioning it here will help.

Fixes #11300.

Change-Id: Ica7f10d749731704ac6a2c39c7dcba389996011e
Reviewed-on: https://go-review.googlesource.com/11236
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned adg Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@josharian @rakyll @andybons @ianlancetaylor @adg @gopherbot