Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/cmd/gomobile: TestWriter is broken #11297

Closed
rakyll opened this issue Jun 19, 2015 · 1 comment
Closed

x/mobile/cmd/gomobile: TestWriter is broken #11297

rakyll opened this issue Jun 19, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@rakyll
Copy link
Contributor

rakyll commented Jun 19, 2015 

go test golang.org/x/mobile/cmd/gomobile

--- FAIL: TestWriter-8 (0.02s)
    writer_test.go:75: unexpected output from aapt
    writer_test.go:80: --- /var/folders/00/1b8h8000h01000cxqpysvccm005d21/T/gofmt349716645  2015-06-19 10:20:25.000000000 -0700
        +++ /var/folders/00/1b8h8000h01000cxqpysvccm005d21/T/gofmt849427392 2015-06-19 10:20:25.000000000 -0700
        @@ -1,3 +1,30 @@
        -It appears you do not have 'build-tools-20.0.0' installed.
        -Use the 'android' tool to install them:
        -    android update sdk --no-ui --filter 'build-tools-20.0.0'
        +AndroidManifest.xml
        +assets/hello_world.txt
        +META-INF/MANIFEST.MF
        +META-INF/CERT.SF
        +META-INF/CERT.RSA
        +
        +Resource table:
        +Package Groups (0)
        +
        +Android manifest:
        +N: android=http://schemas.android.com/apk/res/android
        +  E: manifest (line=2)
        +    A: package="org.golang.fakeapp" (Raw: "org.golang.fakeapp")
        +    A: android:versionCode(0x0101021b)=(type 0x10)0x1
        +    A: android:versionName(0x0101021c)="1.0" (Raw: "1.0")
        +    E: uses-sdk (line=8)
        +      A: android:minSdkVersion(0x0101020c)=(type 0x10)0x9
        +    E: application (line=9)
        +      A: android:label(0x01010001)="FakeApp" (Raw: "FakeApp")
        +      A: android:hasCode(0x0101000c)=(type 0x12)0x0
        +      A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff
        +      E: activity (line=10)
        +        A: android:name(0x01010003)="android.app.NativeActivity" (Raw: "android.app.NativeActivity")
        +        A: android:label(0x01010001)="FakeApp" (Raw: "FakeApp")
        +        A: android:configChanges(0x0101001f)=(type 0x11)0xa0
        +        E: intent-filter (line=14)
        +          E: action (line=15)
        +            A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
        +          E: category (line=16)
        +            A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
FAIL
FAIL    golang.org/x/mobile/cmd/gomobile    0.265s
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jun 19, 2015
hyangah added a commit to golang/mobile that referenced this issue Jun 19, 2015
@hyangah
cmd/gomobile: fix the use of diff function.
1edfb83 
The params order matters in diff function's output.
Related to the confusing error report seen in golang/go#11297

Change-Id: Ibde615dbe43a4393232b72230fb21d7b577c0812
Reviewed-on: https://go-review.googlesource.com/11258
Reviewed-by: Burcu Dogan <jbd@google.com>
@hyangah
Copy link
Contributor

hyangah commented Jun 19, 2015

The relevant info is in the diff message. I guess the aapt binary used in your environment needed extra configuration - e.g. android update sdk --no-ui --filter 'build-tools-20.0.0'

-It appears you do not have 'build-tools-20.0.0' installed.
-Use the 'android' tool to install them:

  • android update sdk --no-ui --filter 'build-tools-20.0.0'

Let me know if the problem persists even after that. I cannot reproduce it in my environment.

@hyangah hyangah closed this as completed Jun 19, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned hyangah Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rakyll @ianlancetaylor @hyangah @gopherbot