Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/cmd/gomobile: improve the readability of runInit(cmd *command) error #11296

Closed
rakyll opened this issue Jun 19, 2015 · 2 comments
Closed

Comments

@rakyll
Copy link
Contributor

rakyll commented Jun 19, 2015

runInit(cmd *command) error is a long block. It might be improved by being split in multiple functions or by the introduction of higher level abstractions. We might introduce a high-level build/init package out of the cmd package, in a similar fashion of go/build and cmd/gomobile can simply invoke the x/mobile/build package.

/cc @crawshaw @hyangah

@rakyll rakyll added this to the Unreleased milestone Jun 19, 2015
@gopherbot
Copy link

CL https://golang.org/cl/11814 mentions this issue.

crawshaw added a commit to golang/mobile that referenced this issue Jul 1, 2015
While here, make the output of -v easier to read.

Fixes golang/go#11295, golang/go#11296.

Change-Id: I51974a3443bb60a5c0bb77ac784e48987eee8391
Reviewed-on: https://go-review.googlesource.com/11814
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@crawshaw
Copy link
Member

I'm pretty happy with the state of the init subcommand now.

@golang golang locked and limited conversation to collaborators Jul 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants