Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime: ParseMediaType parses invalid media types #11289

Closed
dvyukov opened this issue Jun 19, 2015 · 3 comments
Closed

mime: ParseMediaType parses invalid media types #11289

dvyukov opened this issue Jun 19, 2015 · 3 comments
Milestone

Comments

@dvyukov
Copy link
Member

dvyukov commented Jun 19, 2015

The following program fails with the panic:

package main

import (
    "mime"
    "fmt"
)

func main() {
    sdata := "0"
    mt, params, err := mime.ParseMediaType(sdata)
    if err != nil {
        return
    }
    sdata1 := mime.FormatMediaType(mt, params)
    _, _, err = mime.ParseMediaType(sdata1)
    if err != nil {
        fmt.Printf("%q(%q, %+v) -> %q\n", sdata, mt, params, sdata1)
        panic(err)
    }
}
"0"("0", map[]) -> ""
panic: mime: no media type

If "0" is not a valid mediatype, then the first ParseMediaType should produce an error.

go version devel +514014c Thu Jun 18 15:54:35 2015 +0200 linux/amd64

@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Jun 19, 2015
@rsc
Copy link
Contributor

rsc commented Nov 30, 2015

@bradfitz, can you look at this and #11290 and #11291? I assume they're all kind of the same.

@bradfitz
Copy link
Contributor

Will do.

@gopherbot
Copy link

CL https://golang.org/cl/17135 mentions this issue.

@golang golang locked and limited conversation to collaborators Dec 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants