Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/gob: integer comparison is always false #11279

Closed
tzneal opened this issue Jun 19, 2015 · 1 comment
Closed

encoding/gob: integer comparison is always false #11279

tzneal opened this issue Jun 19, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@tzneal
Copy link
Member

tzneal commented Jun 19, 2015

encoding/gob/decode.go:637: comparison of identifier nr < 0 is always false

nr is a uint64 and can never be less than zero

func (state *decoderState) decodeUint() (x uint64) {
        b, err := state.b.ReadByte()
...
        nr := state.decodeUint()
        if nr < 0 || nr > 1<<31 { // zero is permissible for anonymous types
                errorf("invalid type name length %d", nr)
        }
@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Jun 19, 2015
@gopherbot
Copy link

CL https://golang.org/cl/13876 mentions this issue.

@golang golang locked and limited conversation to collaborators Aug 24, 2016
@rsc rsc unassigned robpike Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
4 participants
@tzneal @ianlancetaylor @robpike @gopherbot