-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/asm: integer comparison is always false #11278
Labels
Milestone
Comments
The fix should have been to change shift < 0 to int64(shift) < 0. |
Replied to CL. |
I believe this is finally fixed. If not, please don't make any more changes before Go 1.5 is released. |
It is fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
cmd/asm/internal/asm/parse.go:817: comparison of identifier shift < 0 is always false
shift is a uint64, and can never be negative. The check and error is unreachable code.
The text was updated successfully, but these errors were encountered: