We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan 9's network code in src/net/tcpsockopt_plan9.go contains this questionable piece of code writing to the ctl file:
// Set keep alive period. func setKeepAlivePeriod(fd *netFD, d time.Duration) error { cmd := "keepalive " + string(int64(d/time.Millisecond)) _, e := fd.ctl.WriteAt([]byte(cmd), 0) return e }
Is that really the Plan 9 interface? Or should be it strconv.Itoa instead?
Otherwise it's actually writing something like "keepalive Ϩ" if d is 1 * time.Second.
"keepalive Ϩ"
1 * time.Second
The text was updated successfully, but these errors were encountered:
Yes, this code is incorrect. The period should be the milliseconds as a string. This is described in the ip(3) manual. Thanks for noticing.
Sorry, something went wrong.
CL https://golang.org/cl/11860 mentions this issue.
e6a0c21
No branches or pull requests
Plan 9's network code in src/net/tcpsockopt_plan9.go contains this questionable piece of code writing to the ctl file:
Is that really the Plan 9 interface? Or should be it strconv.Itoa instead?
Otherwise it's actually writing something like
"keepalive Ϩ"
if d is1 * time.Second
.The text was updated successfully, but these errors were encountered: