You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mail rejects to update the reviewer list if there are no staged changes. This behaviour is breaking a common use-case where the contributor creates a CL with no reviewers, review his/her changes on Gerrit and add reviewers. Allow mail subcommand to update the reviewers list even if there are no changes.
The text was updated successfully, but these errors were encountered:
Have the git-codereview tool do a git diff HEAD $BRANCH.mailed and—if there are no changes—use the Gerrit API to adjust the reviewers list instead of doing a git push.
I'd prefer to do the former rather than the latter. If @spearce indicates that this can happen on the Gerrit side, then I'll close this issue. Otherwise we should think about working around it on the git-codereview side.
Yes, it's the behaviour above I was referring to. I assume the latter solution is easy to implement and it must relatively harder to get this done at the Gerrit side not to break the current behavioral compatibility.
mikioh
changed the title
x/review: mail must update the reviewer list even if there are no staged changes
x/review/git-codereview: mail must update the reviewer list even if there are no staged changes
Aug 17, 2015
mail rejects to update the reviewer list if there are no staged changes. This behaviour is breaking a common use-case where the contributor creates a CL with no reviewers, review his/her changes on Gerrit and add reviewers. Allow mail subcommand to update the reviewers list even if there are no changes.
The text was updated successfully, but these errors were encountered: