Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestOpenLanManServer now runs as TestOpenLanManServer-2 #11157

Closed
alexbrainman opened this issue Jun 11, 2015 · 4 comments
Closed

cmd/go: TestOpenLanManServer now runs as TestOpenLanManServer-2 #11157

alexbrainman opened this issue Jun 11, 2015 · 4 comments
Labels
FrozenDueToAge

Comments

@alexbrainman
Copy link
Member

From our builder http://build.golang.org/log/b777dbdb4f736aafe2eacbccee3c499bf7729625

--- FAIL: TestOpenLanManServer-2 (0.00s)
mgr_test.go:23: SCM connection failed: Access is denied.
FAIL
FAIL golang.org/x/sys/windows/svc/mgr 0.043s

(reported as issue #11156)

Test that used to run as TestOpenLanManServer now is running as TestOpenLanManServer-2. Perhaps this is the reason for test failure (maybe not). Is that intentional change with our tests? Is that something we need to document somewhere? Perhaps something else to do here.

Alex
@bradfitz
Copy link
Contributor

That's because GOMAXPROCS now equals NumCPU by default, not 1.

@alexbrainman
Copy link
Member Author

I know that. I just wander how many people's tests will get broken. And if we can do anything about it.

Alex

@alexbrainman
Copy link
Member Author

@bradfitz build bots are nice. I enjoyed watching @ianlancetaylor writing new test with their help yesterday. Thank you and @adg.

Alex

@alexbrainman
Copy link
Member Author

Dup of #11200.

@michael-schaller michael-schaller mentioned this issue Jun 15, 2015
Closed
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradfitz @gopherbot @alexbrainman