Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/app: rename GetConfig #10899

Closed
rakyll opened this issue May 18, 2015 · 1 comment
Closed

x/mobile/app: rename GetConfig #10899

rakyll opened this issue May 18, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@rakyll
Copy link
Contributor

rakyll commented May 18, 2015

Getters shouldn't include a Get prefix. Please find a better name.

cc/ @crawshaw @hyangah @minux
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jun 3, 2015
@crawshaw
Copy link
Member

In general yes, but a Get prefix is sometimes used when the obvious symbol name is already taken by a type with the same name.

But regardless this is now obsolete, as the move to an event channel got rid of GetConfig.

@golang golang locked and limited conversation to collaborators Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rakyll @crawshaw @ianlancetaylor @gopherbot