Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: delete deprecated Callbacks type #10896

Closed
rakyll opened this issue May 18, 2015 · 6 comments
Closed

x/mobile: delete deprecated Callbacks type #10896

rakyll opened this issue May 18, 2015 · 6 comments

Comments

@rakyll
Copy link
Contributor

rakyll commented May 18, 2015

The callback terminology feels odd in Go code. We should rather call them Handlers. I have surveyed godoc to see how community feels and saw only a few instances of the use of callback term. The standard library and the community emerges in the use of handlers. If we keep the callback terminology around, it might give a false impression that they are of another kind of handlers. Let's clean the mobile repo from callbacks and call them handlers.

/cc @crawshaw @hyangah @minux

@minux
Copy link
Member

minux commented May 18, 2015 via email

@rakyll
Copy link
Contributor Author

rakyll commented Jun 21, 2015

Anyone else agrees or disagrees? Go 1.5 will ship a stable app package. If we don't want it to be moved to exp, we either need to make the renaming or close this issue as a WONTFIX.

@crawshaw
Copy link
Member

I'm still idly thinking about this. Handlers is fine, but I'm not really bothered by Callbacks. Either way, @nigeltao is exploring an events channel and that should happen first.

@rakyll
Copy link
Contributor Author

rakyll commented Jun 22, 2015

I'd like to see a design doc for such a significant change.

@nigeltao
Copy link
Contributor

Yes, I want to delete Callbacks, not rename them.

I have the code working, but what's taking up my time now is writing the comments, or what would effectively be a design doc. :-)

@nigeltao
Copy link
Contributor

I still need to write more commentary or "design" comments, and I still haven't patched all of the examples or e.g. the sprite code, but here's a work in progress: https://go-review.googlesource.com/11351

@crawshaw crawshaw changed the title x/mobile: rename Callbacks type x/mobile: delete deprecated Callbacks type Jul 13, 2015
@golang golang locked and limited conversation to collaborators Jul 18, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
It has to go sometime.

Fixes golang/go#10896.

Change-Id: I2ac1437e1d5913c09060931454bf11c3f742ef87
Reviewed-on: https://go-review.googlesource.com/12337
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
It has to go sometime.

Fixes golang/go#10896.

Change-Id: I2ac1437e1d5913c09060931454bf11c3f742ef87
Reviewed-on: https://go-review.googlesource.com/12337
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants