-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/pprof: go tool pprof starts the prof without binary #10863
Comments
Note: Only Googlers can work on this, because pprof in go 1.5 is just a copy of internal source according to https://github.com/golang/go/blob/master/src/cmd/pprof/README |
Not true. Hack on Go's version at will. We'll deal with synchronizing with Google's version occasionally in batches. |
Starting a pprof without the binary is still helpful if the profile contains symbol info like when fetched via the net/http/pprof endpoint. |
This keeps tripping people up (see #14324 for instance). Is it possible for pprof to give an error, or at least a warning, if it detects this bad usage? (i.e. no binary and the profile doesn't contain the necessary symbols itself to be useful.) |
CL https://golang.org/cl/23323 mentions this issue. |
@rakyll my report we discussed was a duplicate, here is the one you might want to track :) |
From the 1.9 release notes ( https://golang.org/doc/go1.9#go-tool-pprof )
I think this can be closed. |
Yay. |
go version go1.4.1 linux/amd64
where i should have typed this
I did fail to read the help correctly so it is my own fault - but it gave me no indication i did anything wrong.
ref: https://groups.google.com/forum/#!topic/Golang-Nuts/dd9QwwGdt34
The text was updated successfully, but these errors were encountered: