Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/event: rename event package to touch #10852

Closed
rakyll opened this issue May 14, 2015 · 2 comments
Closed

x/mobile/event: rename event package to touch #10852

rakyll opened this issue May 14, 2015 · 2 comments

Comments

@rakyll
Copy link
Contributor

rakyll commented May 14, 2015

Across the mobile repo, all of the sub-packages are named after their functionalities and export their own event types. This is not the case for the event package. The name suggests that it's a catch-all bucket containing all available events, but it actually only exports the touch event.

We should rename this package to "touch" and its event type to "Event" in order to keep the consistency.

/cc @crawshaw @hyangah

@minux
Copy link
Member

minux commented May 14, 2015

Dup of #10444.

@minux minux closed this as completed May 14, 2015
@rakyll
Copy link
Contributor Author

rakyll commented May 14, 2015

Lost memories... Sorry for the noise.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants