-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/pprof: TestCPUProfileMultithreaded has too few samples on Windows #10842
Comments
The bigger problem here is that there were only 4 CPU samples collected in 0.44 seconds. That sounds like the sampling is doing 10 Hz instead of 100 Hz. |
I suspect it is all what schedule does. Ours together with Windows scheduler. It varies between different environments - how many CPUs you have, whether you're running in VM or not. My windows xp 386 2*CPU:
Another vm windows 7 amd64 1*CPU:
As far as I remember, I have seen numbers vary if your PC is busy doing other staff. It has been a while since I have seen this issue on our builders. Alex |
Maybe timeBeginPeriod call failed in os1_windows.go? That would give 15ms timer precision instead of 1ms. |
CL https://golang.org/cl/12529 mentions this issue. |
No, it didn't - https://go-review.googlesource.com/#/c/12546/ Alex |
Random test failure:
windows-amd64-gce at 5c7f944
http://build.golang.org/log/135576b3d6ecdc234707e6e75b2829b9c6ea5bef
No flaky tests are tolerated. Let's deflake or delete.
/cc @alexbrainman @dvyukov @minux
The text was updated successfully, but these errors were encountered: