sort: StringSlice broken? #10792

coss · 2015-05-12T20:19:24Z

Maybe I'm missing something, but StringSlice seems broken. The documentation of sort.Strings says

Strings sorts a slice of strings in increasing order.

so I would exptect that it would sort by length instead of comparing lexically byte-wise.

Example:

a := []string{"A", "Ab", "Abc", "Abcd", "Xyz", "Yz", "Z"}
b := []string{"", "Hello", "foo", "bar", "foo", "f00", "%*&^*&^&", "***"}

Expect:

a = ["A", "Z", "Ab", "Yz", "Abc", "Xyz", "Abcd"]
b = ["", "***", "bar", "foo", "foo", "f00", "Hello", "%*&^*&^&"]

Got:

a = ["A", "Ab", "Abc", "Abcd", "Xyz", "Yz", "Z"]
b = ["", "%*&^*&^&", "***", "Hello", "bar", "f00", "foo", "foo"]

Note that the test case just tests that the input is sorted instead of comparing it against a expected fixture.

The text was updated successfully, but these errors were encountered:

randall77 · 2015-05-12T20:28:28Z

Working as intended. Increasing means lexicographically increasing here. We might want to update the docs.

randall77 · 2015-05-12T20:32:04Z

Actually, the docs look pretty clear. The ordering is just < on strings.

randall77 closed this as completed May 12, 2015

golang locked and limited conversation to collaborators Jun 25, 2016

gopherbot added the FrozenDueToAge label Jun 25, 2016

Provide feedback