Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: mail should reject empty commits #10753

Closed
minux opened this issue May 7, 2015 · 2 comments
Closed

x/review/git-codereview: mail should reject empty commits #10753

minux opened this issue May 7, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@minux
Copy link
Member

minux commented May 7, 2015

git change passes --allow-empty to git commit so that it can create a
new branch with an empty commit to work with.

However, it's also possible that the user forgets to git add the file, and
mail the empty commit out to Gerrit. git mail should check for that case
and suggest git add or git chagne -a.

/cc @adg
@minux minux added this to the Unreleased milestone May 7, 2015
@robpike
Copy link
Contributor

robpike commented May 8, 2015

I agree. The overlap of git branch and git change is error-prone.

@gopherbot
Copy link

CL https://golang.org/cl/19799 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 28, 2017
@rsc rsc unassigned adg Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@minux @robpike @adg @gopherbot