Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/openpgp: infinite loop on compression quines #10751

Closed
kbsriram opened this issue May 7, 2015 · 2 comments
Closed

x/crypto/openpgp: infinite loop on compression quines #10751

kbsriram opened this issue May 7, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@kbsriram
Copy link

kbsriram commented May 7, 2015

A carefully crafted packet can cause the ReadMessage function to push an infinite number of io.Readers within the packet reader.

An example packet created by Taylor R. Campbell can be found at:
http://mumble.net/~campbell/misc/pgp-quine/
and additional details can be found from this related issue for GnuPG:
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2013-4402
@ianlancetaylor
Copy link
Contributor

CC @agl

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone May 7, 2015
@ebfe
Copy link
Contributor

ebfe commented Jul 18, 2015

This has been fixed in golang/crypto@24ffb5feb

@agl agl self-assigned this Aug 2, 2015
@agl agl closed this as completed Aug 2, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Nov 24, 2019
@kbsriram @agl
x/crypto/openpgp: Limit packet recursion depth.
24ffb5f 
A carefully crafted packet can cause the packet reader to push an
infinite number of recursive packet readers. This change limits
the number of recursive parsing levels within the packet reader.

More details at:
http://mumble.net/~campbell/misc/pgp-quine
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2013-4402

Fixes golang#10751

Change-Id: Ib4e102d85f6496e2c7feb5b9d7e5db45db6032df
Reviewed-on: https://go-review.googlesource.com/9843
Reviewed-by: Adam Langley <agl@golang.org>
@rsc rsc unassigned agl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@agl @ebfe @kbsriram @ianlancetaylor @gopherbot