Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: can't access C.Stdout if stdout is a macro #10715

Closed
4ad opened this issue May 6, 2015 · 3 comments
Closed

cmd/cgo: can't access C.Stdout if stdout is a macro #10715

4ad opened this issue May 6, 2015 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.10

Comments

@4ad
Copy link
Member

4ad commented May 6, 2015

This affects Windows, NetBSD, OpenBSD and Solaris. Ian suggested cgo should detect this special case and make it work.
@4ad 4ad changed the title cmd/cgo: can't access C.Stdout is stdout is a macro cmd/cgo: can't access C.Stdout if stdout is a macro May 6, 2015
4ad added a commit that referenced this issue May 6, 2015
@4ad
doc/progs: disable cgo tests that use C.Stdout on Solaris
2d18ab7 
Solaris, like Windows, NetBSD and OpenBSD, uses macros for stdin, stdout,
and stderr. Cgo can't access them without getters/setters written in
C. Because of this we disable affected tests like for the other platforms.

Updates #10715.

Change-Id: I3d33a5554b5ba209273dbdff992925a38a281b42
Reviewed-on: https://go-review.googlesource.com/8264
Reviewed-by: Minux Ma <minux@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Jun 3, 2015
@bradfitz bradfitz modified the milestones: Go1.8Maybe, Unplanned Jul 31, 2016
tsudoko added a commit to tsudoko/go.tesseract that referenced this issue Aug 14, 2016
@tsudoko
Apply a workaround for golang/go#10715
9a63e23
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 10, 2016
@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Nov 2, 2016
@gopherbot
Copy link

CL https://golang.org/cl/43970 mentions this issue.

@ALTree
Copy link
Member

ALTree commented Jun 3, 2017

There's a CL for this but it's unfinished (still marked DO NOT REVIEW) and we're deep in the freeze, so moving this to the go1.10 milestone.

@ALTree ALTree modified the milestones: Go1.10, Go1.9 Jun 3, 2017
@gopherbot
Copy link

Change https://golang.org/cl/86475 mentions this issue: cmd/cgo: support niladic macros for gccgo

gopherbot pushed a commit that referenced this issue Jan 10, 2018
@ianlancetaylor
cmd/cgo: support niladic macros for gccgo
1b89dad 
https://golang.org/cl/43970 changed writeOutputFunc to support niladic
function-like macros; apply the corresponding change to
writeGccgoOutputFunc.

Updates #10715
Updates #18720

Change-Id: I5decb1d37ec71507466ade2eeda4b89c8785eaef
Reviewed-on: https://go-review.googlesource.com/86475
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Hiroshi Ioka <hirochachacha@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
@golang golang locked and limited conversation to collaborators Jan 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
7 participants
@bradfitz @rsc @quentinmit @4ad @ianlancetaylor @ALTree @gopherbot