I'm all for deleting code, using bufio.Buffer everywhere sounds great.
For 1.5, however, it is a bit late. That's a lot of lines to change after the freeze.

That's fair, but please consider at least applying https://go-review.googlesource.com/#/c/9529/

CL https://golang.org/cl/9660 mentions this issue.

CL https://golang.org/cl/13886 mentions this issue.

I think the original issue was resolved if we are just talking of the copies of Biobuf.
After:

• @mdempsky's CL https://go-review.googlesource.com/#/c/21644 to make package cmd/internal/bio
• @davecheney's CL https://go-review.googlesource.com/#/c/21720 to replace bio.Buf with bio.Reader and bio.Writer
  we now use "cmd/internal/bio" in both.

However, in @davecheney's CL https://go-review.googlesource.com/#/c/21720 he noted at 8f2edf1#diff-c6708995b52ed026c5e6632418f7a3b6R247 that the logic of bio.Writer was duplicated in a small internal struct. Perhaps a new issue to refactor/replace that unexported code can then be opened since the original duplication issue was solved?

Any thoughts?

I think when gri deletes the old importer code from the compiler in 1.8
this should expose a few more places where bio is not used and will
probably seal its fate.

On Fri, Aug 5, 2016 at 6:33 PM, Emmanuel T Odeke notifications@github.com
wrote:

I think the original issue was resolved if we are just talking of the
copies of Biobuf.
After:

• @mdempsky https://github.com/mdempsky's CL https://go-review.
  googlesource.com/#/c/21644 to make package cmd/internal/bio
• @davecheney https://github.com/davecheney's CL https://go-review.
  googlesource.com/#/c/21720 to replace bio.Buf with bio.Reader and
  bio.Writer we now use "cmd/internal/bio" in both.

However, in @davecheney https://github.com/davecheney's CL
https://go-review.googlesource.com/#/c/21720 he noted at 8f2edf1#diff-
c6708995b52ed026c5e6632418f7a3b6R247
8f2edf1#diff-c6708995b52ed026c5e6632418f7a3b6R247
that the logic of bio.Writer was duplicated in a small internal struct.
Perhaps a new issue to refactor/replace that unexported code can then be
opened since the original duplication issue was solved?

Any thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10652 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA96EG36LQHrx837d45Elx0uv00xkks5qcvVUgaJpZM4ENOEP
.

This no longer seems to be the case:

$ git grep -i Biobuf
cmd/link/internal/ld/ldpe.go:// TODO(brainman): maybe just add ReadAt method to bio.Reader instead of creating peBiobuf
cmd/link/internal/ld/ldpe.go:// peBiobuf makes bio.Reader look like io.ReaderAt.
cmd/link/internal/ld/ldpe.go:type peBiobuf bio.Reader
cmd/link/internal/ld/ldpe.go:func (f *peBiobuf) ReadAt(p []byte, off int64) (int, error) {
cmd/link/internal/ld/ldpe.go:   sr := io.NewSectionReader((*peBiobuf)(input), input.Offset(), 1<<63-1)
cmd/vendor/golang.org/x/arch/x86/x86asm/testdata/libmach8db.c:  Biobuf bstdout;