Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: update documentation, example for error values #10624

Closed
mikioh opened this issue Apr 30, 2015 · 8 comments
Closed

net: update documentation, example for error values #10624

mikioh opened this issue Apr 30, 2015 · 8 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@mikioh
Copy link
Contributor

mikioh commented Apr 30, 2015

Suggested in a review of net: fix inconsistent errors (https://go-review.googlesource.com/#/c/9236/):

In a different CL, could you write some documentation about what kinds of errors people can expect, and perhaps an Example function showing how to work with them? See https://groups.google.com/d/msg/golang-nuts/iNVNBXdZK8Q/irnIrgLD2q4J for the kinds of issues programmers want to understand.
@mikioh mikioh added this to the Go1.5Maybe milestone Apr 30, 2015
@rsc rsc modified the milestones: Go1.6Early, Go1.5Maybe Jul 21, 2015
@rsc rsc modified the milestones: Go1.6, Go1.6Early Nov 4, 2015
@rsc rsc modified the milestones: Go1.6Maybe, Go1.6 Jan 7, 2016
@rsc rsc modified the milestones: Unplanned, Go1.6Maybe Jan 14, 2016
@gopherbot
Copy link

CL https://golang.org/cl/20009 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 3, 2016
@cixtor
net: deduplicate TCP socket code
b0f4ee5 
This change consolidates functions and methods related to TCPAddr,
TCPConn and TCPListener for maintenance purpose, especially for
documentation. Also refactors Dial error code paths.

The followup changes will update comments and examples.

Updates #10624.

Change-Id: I3333ee218ebcd08928f9e2826cd1984d15ea153e
Reviewed-on: https://go-review.googlesource.com/20009
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/20120 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/20125 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/20124 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 16, 2016
@cixtor
net: deduplicate UDP socket code
20de705 
This change consolidates functions and methods related to UDPAddr and
UDPConn for maintenance purpose, especially for documentation.

The followup changes will update comments and examples.

Updates #10624.

Change-Id: Idfe9be8ea46ade1111b0ae176862b2048eafc7be
Reviewed-on: https://go-review.googlesource.com/20120
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit that referenced this issue Mar 16, 2016
@cixtor
net: deduplicate raw IP socket code
028e48c 
This change consolidates functions and methods related to IPAddr and
IPConn for maintenance purpose, especially for documentation.

The followup changes will update comments and examples.

Updates #10624.

Change-Id: Ia5146f234225704a3c0b6459e1903e56a7b68134
Reviewed-on: https://go-review.googlesource.com/20124
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit that referenced this issue Mar 16, 2016
@cixtor
net: deduplicate Unix socket code
5ce0170 
This change consolidates functions and methods related to UnixAddr,
UnixConn and UnixListener for maintenance purpose, especially for
documentation.

The followup changes will update comments and examples.

Updates #10624.

Change-Id: I372d152099ac10956284e6b3863d7e4d9fe5c8e9
Reviewed-on: https://go-review.googlesource.com/20125
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@mikioh mikioh modified the milestones: Go1.7, Unplanned Apr 11, 2016
@mikioh mikioh mentioned this issue Apr 11, 2016
Closed
@gopherbot
Copy link

CL https://golang.org/cl/22168 mentions this issue.

@rsc rsc modified the milestones: Go1.8, Go1.7 May 18, 2016
@mikioh mikioh mentioned this issue Jun 9, 2016
Closed
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 7, 2016
@gopherbot
Copy link

CL https://golang.org/cl/31950 mentions this issue.

@rsc rsc modified the milestones: Go1.9Early, Go1.8 Oct 27, 2016
@bradfitz bradfitz added this to the Go1.9Maybe milestone May 3, 2017
@bradfitz bradfitz removed this from the Go1.9Early milestone May 3, 2017
@ianlancetaylor
Copy link
Contributor

@mikioh Is there more to do here?

@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Go1.9Maybe Aug 3, 2017
@mikioh
Copy link
Contributor Author

mikioh commented Aug 3, 2017

I think there's nothing else remains to be done, CLs for docs update in Go 1.9 fixed this issue. Closing.

@mikioh mikioh closed this as completed Aug 3, 2017
@mikioh mikioh modified the milestones: Go1.9, Go1.10 Aug 3, 2017
@golang golang locked and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
6 participants
@bradfitz @mikioh @rsc @quentinmit @ianlancetaylor @gopherbot