-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text/template: leaks goroutines on errors #10614
Comments
@dvyukov how did you know to panic and look at the stack trace for a goroutine stuck on the send channel? go-fuzz seems to be about testing if the error happens inside of the API call by looking for a panic or a wrong error output, this is a very interesting twist to also see if a goroutine is leaked. |
@rambocoder I noticed it accidentally. Since I reuse the same process for thousands of tests, lots of crash reports contained thousands of lexer goroutines in the dump. |
@rambocoder But of course in your own Fuzz function you are free to call runtime.NumGoroutine and panic if the number increases. |
Duplicates #10574 |
Closing as duplicate. |
The following program leaves a hanged goroutine. If a server reloads templates on the fly, this behavior can leads to unbounded number of leaked goroutines.
on commit ccc76db
The text was updated successfully, but these errors were encountered: