You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// Argument y must be either 0 or 1.funcaddVW_g(z, x []Word, yWord) (cWord)
But e.g. running TestFloatSetPrec sends in many values for y. The existing implementations handle them correctly. I care because my initial arm64 implementation transfers y directly to the carry flag at the start, which only works if y is 0 or 1.
subVW does not say that y must be either 0 or 1, but in practice it appears to be, and the semantics are less clear if it is not. However, TestFunVW appears to intentionally send in y=2 to confirm that there's no bad behavior when z and x are nil.
What preconditions do addVW and subVW actually have?
@griesemer feel free to clarify here or just send a CL.
(Additional docs in general in arith.go would be awesome. Right now I'm inferring shlVU and friends from the existing code.)
The text was updated successfully, but these errors were encountered:
I'm working on an arm64 math/big implementation.
The docs for addVW (arith.go) say:
But e.g. running
TestFloatSetPrec
sends in many values for y. The existing implementations handle them correctly. I care because my initial arm64 implementation transfers y directly to the carry flag at the start, which only works if y is 0 or 1.subVW does not say that y must be either 0 or 1, but in practice it appears to be, and the semantics are less clear if it is not. However, TestFunVW appears to intentionally send in y=2 to confirm that there's no bad behavior when z and x are nil.
What preconditions do addVW and subVW actually have?
@griesemer feel free to clarify here or just send a CL.
(Additional docs in general in arith.go would be awesome. Right now I'm inferring shlVU and friends from the existing code.)
The text was updated successfully, but these errors were encountered: