Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compress/flate: TestDeflateInflateString fails #10515

Closed
alexbrainman opened this issue Apr 21, 2015 · 5 comments
Closed

compress/flate: TestDeflateInflateString fails #10515

alexbrainman opened this issue Apr 21, 2015 · 5 comments
Labels
FrozenDueToAge

Comments

@alexbrainman
Copy link
Member 

c:\go\root\src>go version
go version devel +832c573 Tue Apr 21 01:00:11 2015 +0000 windows/amd64

c:\go\root\src>go test -short compress/flate
--- FAIL: TestDeflateInflateString (0.28s)
        deflate_test.go:288: level: 0, len(compress(data)) = 100019 > limit = 100018
        deflate_test.go:197: --testSync 1, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 2, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 3, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 4, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 5, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 6, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 7, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 8, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
        deflate_test.go:197: --testSync 9, 100004, 2.718281828...
        deflate_test.go:216: #0: write 0-50002
        deflate_test.go:234: #0: read 50002
        deflate_test.go:216: #1: write 50002-100004
        deflate_test.go:234: #1: read 50002
FAIL
FAIL    compress/flate  0.438s
@mdempsky
Copy link
Contributor

It's passing on build.golang.org's windows/amd64 bots. Any idea what's different about this machine? Is it a reliable failure?

I reworked compress/flate somewhat recently. Can you try bisecting to see if one of those CLs caused this?

@mdempsky
Copy link
Contributor

I suspect your git checkout is bad. src/compress/testdata/e.txt should be 100003 bytes large, but it looks like yours is 100004 bytes large. I'm guessing because git converted the line ending to CRLF, which would cause the compressed data to grow slightly, and cause the test to fail.

@alexbrainman
Copy link
Member Author

Indeed extra CR in src/compress/testdata/e.txt was the problem. I was debugging some old code, and did "git checkout go1.4". go1.4 version does not have .gitattributes file. So moving between go1.4 and master with "git checkout" does not handle line ends properly. Deleting all files and "git reset --hard" does the job.

Thanks for your help.

Alex

@minux
Copy link
Member

minux commented Apr 21, 2015 via email

@alexbrainman
Copy link
Member Author

I think it is everywhere now. I am talking about go1.4 label.

Alex

@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdempsky @minux @gopherbot @alexbrainman