Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: possible to lose CancelRequest between getConn and roundTrip #10511

Closed
bradfitz opened this issue Apr 20, 2015 · 1 comment
Closed

net/http: possible to lose CancelRequest between getConn and roundTrip #10511

bradfitz opened this issue Apr 20, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@bradfitz
Copy link
Contributor

As noted by @DanielMorsing, it's possible to lose a Transport.CancelRequest between dialing the conn and roundTrip.

There exists a small window where the cancel request is still:

        t.setReqCanceler(req, func() { close(cancelc) })

... but we've already dialed, but we haven't yet entered roundTrip and its:

    pc.t.setReqCanceler(req.Request, pc.cancelRequest)
@bradfitz bradfitz added this to the Go1.5Maybe milestone Apr 20, 2015
@DanielMorsing
Copy link
Contributor

https://go-review.googlesource.com/#/c/9181/

@mikioh mikioh modified the milestones: Go1.5, Go1.5Maybe May 15, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@bradfitz @mikioh @DanielMorsing @gopherbot