-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/webdav: windows & gvfs does not accept as a webdav server #10506
Comments
That's odd. AFAIK litmus_test_server.go defines a PropSystem, and webdav.go should honor PROPFIND. Can you give a more detailed error message? |
Also, what's the "g" in "gvfs"? GNOME? If so, is GVFS happy if the litmus_test_server runs on Linux instead of Windows? |
Possibly related: https://go-review.googlesource.com/#/c/9193/ fixes #10517 on Windows. |
test fail on my environment (windows7).
however, i'm thinking this is an issue of test code because first argument of walkFn should be a local path. i think. |
That test failure is issue #10517, fixed by 9193, as previously mentioned. |
I still see --- FAIL: TestMultistatusWriter (0.01s) |
Huh, it's not obvious what the string difference is in the first failure message. If you change the last non-trivial line of xml_test.go from t.Errorf("%s: XML body\ngot %q\nwant %q", tc.desc, gotXML, wantXML) to t.Errorf("%s: XML body\ngot % x\nwant % x", tc.desc, gotXML, wantXML) (and note the space between the % and x), then what does the first error message in TestMultistatusWriter become? |
First of all, sorry for some of the noise, I've used (cd litmus-0.13 && ./http http://localhost:9999) instead of (cd litmus-0.13 && make URL=http://localhost:9999 check) - I didn't noticed it does different things. With the latest changes, the litmus test is: -> running `basic':
But gvfs (under Debian the gvfsd-bin package, version 1.22.2) still unhappy: gthomas@waterhouse:~/src/golang.org/x/net/webdav$ git log --oneline|head gthomas@waterhouse:~/src/golang.org/x/net/webdav$ go run litmus_test_server.go gthomas@waterhouse:~$ gvfs-mount -i dav://localhost:9999/ |
--- FAIL: TestMultistatusWriter (0.01s) 2015-04-22 6:42 GMT+02:00 Nigel Tao notifications@github.com:
|
got <multistatus xmlns="DAV:" xmlns="DAV:" xmlns="DAV:"><response xmlns="DAV:" xmlns
="DAV:"><href xmlns="DAV:" xmlns="DAV:">http://example.com/foo</href><propstat x
mlns="DAV:" xmlns="DAV:"><prop xmlns="DAV:"><Authors xmlns="http://ns.example.co
m/" xmlns="http://ns.example.com/"></Authors></prop><status xmlns="DAV:" xmlns="
DAV:">HTTP/1.1 424 Failed Dependency</status></propstat><propstat xmlns="DAV:" x
mlns="DAV:"><prop xmlns="DAV:"><Copyright-Owner xmlns="http://ns.example.com/" x
mlns="http://ns.example.com/"></Copyright-Owner></prop><status xmlns="DAV:" xmln
s="DAV:">HTTP/1.1 409 Conflict</status></propstat><responsedescription xmlns="DA
V:" xmlns="DAV:">Copyright Owner cannot be deleted or altered.</responsedescript
ion></response></multistatus> want <multistatus xmlns="DAV:" xmlns="DAV:"><response xmlns="DAV:"><href xmlns="DAV:"
>http://example.com/foo</href><propstat xmlns="DAV:"><prop xmlns="DAV:"><Authors
xmlns="http://ns.example.com/" xmlns="http://ns.example.com/"></Authors></prop>
<status xmlns="DAV:">HTTP/1.1 424 Failed Dependency</status></propstat><propstat
xmlns="DAV:" xmlns="DAV:"><prop xmlns="DAV:"><Copyright-Owner xmlns="http://ns.
example.com/" xmlns="http://ns.example.com/"></Copyright-Owner></prop><status xm
lns="DAV:">HTTP/1.1 409 Conflict</status></propstat><responsedescription xmlns="
DAV:">Copyright Owner cannot be deleted or altered.</responsedescription></respo
nse></multistatus> |
CC @rsto. |
It looks like there are two, possibly unrelated, issues here. @mattn The XML normalisation that we employ for our "golden XML" tests seems broken in your environment. Are you testing this on current master? The multiple namespace definitions in your XML dump hint at a problem in the XML package that recently has been fixed by Roger Peppe. Could you please retry with a recent Go version that, as a minimum, includes the following CLs:
As an additional data point, It works for me with go version devel +ecd630d. The most recent master should include all the XML goodness. @tgulacsi I see that you are on go devel, but are you sure your version includes the afore mentioned XML fixes? Also, could you please paste the full OPTIONS/PROPFIND HTTP transfer here? Gvfs might choke because the XML marshalling is broken in your environment, or it might because of a bug in the property system implementation. Without the HTTP trace I can't really tell. FYI f you run litmus like
it will only run the props suite. On my machine, this outputs
|
@rsto i didn't repro. I just converted hex code to xml string. :) |
Nope, I'm on 1.4.2. I'll try with head soon, 2015-04-22 9:47 GMT+02:00 Nigel Tao notifications@github.com:
|
Ok, so golang.org/x/net/webdav works perfectly with go head: tgulacsi@tgulacsi-Aspire-V3-371: And works with gvfs flawlessly! So, thanks for the great work, and sorry for the noise! |
As I see gvfs starts with a PROPFIND (I'm using litmus_test_server.go).
(By the way, at the moment go test fails, too).
I'm not a DAV expert at all, but I'd really like to have this work with Windows (for camlistore.org :)).
Where should I start? What's missing, or known lack of care?
The text was updated successfully, but these errors were encountered: