Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm, cmd/old5a, etc: -trimpath no longer works #10503

Closed
mdempsky opened this issue Apr 20, 2015 · 1 comment
Closed

cmd/asm, cmd/old5a, etc: -trimpath no longer works #10503

mdempsky opened this issue Apr 20, 2015 · 1 comment
Labels
FrozenDueToAge

Comments

@mdempsky
Copy link
Member

The -trimpath flag for the assembler tools no longer seems to work. It looks like it's probably broken for cmd/5g, etc. too.

cmd/old5a, cmd/5g, etc. use the -trimpath flag to directly set ctxt.Trimpath. cmd/asm uses it to set a TrimPath var, which is then copied into ctxt.Trimpath. In any case, the Trimpath field is never read from.

cmd/internal/obj's LineHist struct type has a TrimPathPrefix field, but it's never assigned to.
@mdempsky
Copy link
Member Author

Looks like this is a regression due to 8615465. I'll send a fix.

@mdempsky mdempsky self-assigned this Apr 20, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot