Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/cmd/gomobile: remove reference to old5a in init #10496

Closed
hyangah opened this issue Apr 17, 2015 · 2 comments
Closed

x/mobile/cmd/gomobile: remove reference to old5a in init #10496

hyangah opened this issue Apr 17, 2015 · 2 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 17, 2015

gomobile uses -toolexec build flag to invoke toolchains for android.
As a side-effect, it ends up using old tools

cd /usr/local/google/home/hakim/golang/gopaths/ws4/src/golang.org/x/mobile/app/internal/callfn
/usr/local/google/home/hakim/golang/gopaths/ws4/pkg/gomobile/android-ndk-r10d/arm/bin/toolexec /usr/local/google/home/hakim/golang/goroots/newgo/go/pkg/tool/linux_amd64/old5a -o $WORK/golang.org/x/mobile/app/internal/callfn/_obj/callfn_arm.5.new -trimpath $WORK -I $WORK/golang.org/x/mobile/app/internal/callfn/_obj/ -I /usr/local/google/home/hakim/golang/goroots/newgo/go/pkg/include -D GOOS_android -D GOARCH_arm ./callfn_arm.s
pack r $WORK/golang.org/x/mobile/app/internal/callfn.a $WORK/golang.org/x/mobile/app/internal/callfn/_obj/callfn_arm.5 # internal
mkdir -p $WORK/golang.org/x/mobile/gl/_obj/

(see https://github.com/golang/go/blob/master/src/cmd/go/build.go#L1909)

An easy option is to make gomobile's toolexec command rewrite the build command to use asm if old5a is requested.

@hyangah hyangah changed the title x/mobile/cmd/gomobile: gomobile uses old5a instead of asm. x/mobile/cmd/gomobile: remove reference to old5a in init Apr 20, 2015
@hyangah
Copy link
Contributor Author

hyangah commented Apr 20, 2015

revert https://go-review.googlesource.com/9034 when #10510 is fixed and old*a tools are deleted before release.

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jun 3, 2015
@crawshaw
Copy link
Member

Fixed by golang/mobile@743b9bf.

@golang golang locked and limited conversation to collaborators Jul 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants