Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: darwin/arm defaults to -p 1 for testing, which unnecessarily slows down building #10477

Closed
crawshaw opened this issue Apr 16, 2015 · 2 comments
Closed

cmd/go: darwin/arm defaults to -p 1 for testing, which unnecessarily slows down building #10477

crawshaw opened this issue Apr 16, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@crawshaw
Copy link
Member

We set -p 1 by default for darwin/arm, because it's impossible to run more than one test at a time on the iOS device (each test is packaged as an app for execution).

https://github.com/golang/go/blob/master/src/cmd/go/build.go#L137

As a result, stdlib builds also happen one package at a time on the host, which can be a bit frustrating when you're looking for a compiler error.

Just for this I don't think it's worth complicating the go command to separate the notions of parallelism, but if some other changes happen to its work scheduling, parallel darwin/arm builds would be nice to have.
@crawshaw crawshaw added this to the Unplanned milestone Apr 16, 2015
@minux
Copy link
Member

minux commented Apr 16, 2015 via email

@crawshaw crawshaw self-assigned this Jul 24, 2015
@crawshaw crawshaw modified the milestones: Go1.6, Unplanned Jul 24, 2015
@rsc rsc modified the milestones: Unplanned, Go1.6 Nov 5, 2015
@gopherbot
Copy link

CL https://golang.org/cl/21186 mentions this issue.

@golang golang locked and limited conversation to collaborators Aug 16, 2017
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
mobile/cmd/gomobile: remove explicit -p argument to the go cmd
5151549 
Now that darwin/arm no longer use an explicit -p=1 in the go command
remove the explicit -p=<num cpus> from gomobile as well.

While we're here, fix the init test templates to reflect the new
clang based build.

Fixes golang/go#10477

Change-Id: I29a179e628466ae0c591620f485194b80e310811
Reviewed-on: https://go-review.googlesource.com/21186
Reviewed-by: David Crawshaw <crawshaw@golang.org>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
mobile/cmd/gomobile: remove explicit -p argument to the go cmd
a1f3876 
Now that darwin/arm no longer use an explicit -p=1 in the go command
remove the explicit -p=<num cpus> from gomobile as well.

While we're here, fix the init test templates to reflect the new
clang based build.

Fixes golang/go#10477

Change-Id: I29a179e628466ae0c591620f485194b80e310811
Reviewed-on: https://go-review.googlesource.com/21186
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@rsc @minux @crawshaw @gopherbot