Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgo: line numbers are wrong #1047

Closed
rsc opened this issue Aug 25, 2010 · 12 comments
Closed

cgo: line numbers are wrong #1047

rsc opened this issue Aug 25, 2010 · 12 comments
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Aug 25, 2010

the //line comment at the beginning of the generated
file is good but then not emitting comments kills the
correspondence between input and output
@rsc
Copy link
Contributor Author

rsc commented Sep 12, 2010

Comment 1:

Issue #856 has been merged into this issue.

@bradfitz
Copy link
Contributor

bradfitz commented May 2, 2011

Comment 2:

Issue #1216 has been merged into this issue.

@gopherbot
Copy link

Comment 3 by jcowgar:

This makes it pretty difficult when developing new wrappers toward the beginning when
mass amounts of code is written between compilations. Not as difficult once you are down
to making one function and compiling, but still very annoying. It causes useless hunting
and interpreting where the problem actually is.
It seems to be a very old bug as far as the language is concerned. Since Aug 2010 :-(

@rsc
Copy link
Contributor Author

rsc commented May 13, 2011

Comment 4:

Patches welcome!

@rsc
Copy link
Contributor Author

rsc commented Dec 9, 2011

Comment 5:

Labels changed: added priority-later.

@rsc
Copy link
Contributor Author

rsc commented Dec 12, 2011

Comment 6:

Labels changed: added priority-go1.

@robpike
Copy link
Contributor

robpike commented Jan 13, 2012

Comment 7:

Owner changed to builder@golang.org.

@bradfitz
Copy link
Contributor

Comment 8:

This might be a dup of issue #2697.
If it is, the example in issue #2697 might be helpful for debugging.

@gopherbot
Copy link

Comment 10 by monnand:

I have fixed this bug. The patch is commited and ready to be reviewed:
http://golang.org/cl/5569084/

@griesemer
Copy link
Contributor

Comment 11:

Work in progress:
http://golang.org/cl/5643066
(not quite ready yet)

Status changed to Started.

@griesemer
Copy link
Contributor

Comment 12:

CL ready for review: http://golang.org/cl/5643066

@griesemer
Copy link
Contributor

Comment 13:

This issue was closed by revision f8cf82f.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 10, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants