Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/url: no way to construct raw unqualified request URI starting with // #10433

Closed
DanielMorsing opened this issue Apr 13, 2015 · 2 comments
Closed

net/url: no way to construct raw unqualified request URI starting with // #10433

DanielMorsing opened this issue Apr 13, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@DanielMorsing
Copy link
Contributor

http://play.golang.org/p/67oKm8TFcm

When I pass the URL in the playground into the http transport, it will call .RequestURI() and do a GET http://foo/bar%2f, while what I actually wanted was GET //foo/bar%2f. It looks like there is no possible way to construct a URL that will query for //foo/bar%2f.

Not quite sure how to distinguish between the case of Opaque containing a qualified URI and an unqualified one starting with //. Does it make sense to look at the host part after the // and see if it matches what's in Host?
@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Jun 3, 2015
@narma narma mentioned this issue Jul 27, 2015
Closed
@narma narma mentioned this issue Jul 27, 2015
Merged
narma pushed a commit to FoxComm/vulcand that referenced this issue Jul 27, 2015
Fix fwd requests starting with //
eee2d21 
Workaround for golang/go#10433
@narma narma mentioned this issue Jul 27, 2015
Closed
nota-ja added a commit to nota-ja/material-design that referenced this issue Oct 27, 2015
@nota-ja
Remove / after baseurl to avoid // problem in Gorouter & net/url
4c96e2b 
* cloudfoundry/gorouter#60
* golang/go#10433

If baseurl does not have a trailing `/`, it is added:

* https://github.com/spf13/hugo/blob/6af9d6789edef483cd297978e010b40117ff1443/commands/hugo.go#L209-L211
* https://github.com/spf13/hugo/blob/6af9d6789edef483cd297978e010b40117ff1443/commands/server.go#L89
  * https://github.com/spf13/hugo/blob/6af9d6789edef483cd297978e010b40117ff1443/commands/server.go#L161-L163

So each `/` after baseurl is actually not needed.
@rsc
Copy link
Contributor

rsc commented Dec 4, 2015

This was fixed in Go 1.5: there is now a way to construct this request URI. Don't use Opaque, use RawPath (or just ParseRequestURI). I will add some tests to make sure this keeps working.

http://play.golang.org/p/De3q6SYhE9

@gopherbot
Copy link

CL https://golang.org/cl/17386 mentions this issue.

@rsc rsc closed this as completed in 503cbce Dec 10, 2015
@crhino crhino mentioned this issue Mar 24, 2016
Open
@golang golang locked and limited conversation to collaborators Dec 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
4 participants
@rsc @DanielMorsing @ianlancetaylor @gopherbot