Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: document conditional jumps and branches #10385

Closed
josharian opened this issue Apr 8, 2015 · 3 comments
Closed

cmd/asm: document conditional jumps and branches #10385

josharian opened this issue Apr 8, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@josharian
Copy link
Contributor

cmd/old6a and cmd/old8a document the conditional jumps, e.g.:

    {"JOS", LTYPER, x86.AJOS},  /* overflow set (OF = 1) */
    {"JO", LTYPER, x86.AJOS},   /* alternate */
    {"JOC", LTYPER, x86.AJOC},  /* overflow clear (OF = 0) */
    // lots more...

Let's bring that documentation with us to the new assembler, and cover the other platforms as well.
@josharian josharian added this to the Go1.5 milestone Apr 8, 2015
@josharian
Copy link
Contributor Author

Let's also add docs to ARM.

It might also be helpful to pull in some of @minux's commentary from https://groups.google.com/forum/#!topic/golang-dev/MieNQcSAQNk about the carry flags, or link to it.

@rsc rsc removed the repo-main label Apr 14, 2015
robpike added a commit that referenced this issue Apr 28, 2015
@robpike
cmd/asm: add comments back for aliases on jumps for x86
a88994c 
These were lost in the transition from 8a/6a to asm.
Also, in the process, discover more aliases. I'm betting the missing
ones were a casualty of the recent merge of 386 and amd64.

Update #10385.

Change-Id: I1681034b25af3ffc103f75e5fc57baca5feb3fcd
Reviewed-on: https://go-review.googlesource.com/9431
Reviewed-by: Russ Cox <rsc@golang.org>
@robpike robpike self-assigned this Jul 8, 2015
@robpike
Copy link
Contributor

robpike commented Jul 10, 2015

X86 is done, I believe.

"Add docs to ARM" is a fine thing to ask for, but what docs, and where? Also, putting this in the source for the assembler seems like a poor choice.

Please explain what you want documented or close the issue.

@josharian
Copy link
Contributor Author

I'll add docs next time I need them.

@golang golang locked and limited conversation to collaborators Jul 11, 2016
@rsc rsc unassigned robpike Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@josharian @rsc @robpike @gopherbot