Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: docs do not say that published type must be exported #10379

Closed
dvyukov opened this issue Apr 8, 2015 · 3 comments
Closed

net/rpc: docs do not say that published type must be exported #10379

dvyukov opened this issue Apr 8, 2015 · 3 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.5

Comments

@dvyukov
Copy link
Member

dvyukov commented Apr 8, 2015

Looking at:
http://golang.org/pkg/net/rpc/
There are no mentions that a published type (type of object passed to Register) must be exported. There are only several mentions that methods must be exported.

However, when I try to register a non-exported type, it fails with:
2015/04/08 18:06:45 rpc.Register: type driver is not exported

I guess it is a documentation issue.
@dvyukov dvyukov added this to the Go1.5 milestone Apr 8, 2015
@robpike
Copy link
Contributor

robpike commented Apr 8, 2015

The very first sentence of the package comment reads

Package rpc provides access to the exported methods of an object across a
network or other I/O connection.

@robpike robpike closed this as completed Apr 8, 2015
@robpike
Copy link
Contributor

robpike commented Apr 8, 2015

Moreover,

@robpike robpike reopened this Apr 8, 2015
@robpike
Copy link
Contributor

robpike commented Apr 8, 2015

Ah, I see the distinction. Will fix.

@robpike robpike closed this as completed in 514eb4a Apr 8, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned robpike Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@dvyukov @ianlancetaylor @robpike @gopherbot