Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: SVG profile uses javascript from cyberz.org #10375

Closed
alicebob opened this issue Apr 8, 2015 · 4 comments
Closed

cmd/pprof: SVG profile uses javascript from cyberz.org #10375

alicebob opened this issue Apr 8, 2015 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@alicebob
Copy link
Contributor

alicebob commented Apr 8, 2015

The .svg profile as generated by pprof's web command includes some Javascript from https://www.cyberz.org/projects/SVGPan/SVGPan.js

the file is linked here:

go/src/cmd/pprof/internal/driver/driver.go

Line 628 in 5f84238

flagSVGPan: flag.String("svgpan", "https://www.cyberz.org/projects/SVGPan/SVGPan.js", "URL for SVGPan Library"),

I found it surprising to find pprof's SVG has external dependencies. Not just because of tracking reasons (I don't think cyberz.org need to know about my pprof usage), but also because it doesn't always work (e.g. working on a train).

Would it be possible to just include the javascript code verbatim in the .SVG, or otherwise to not include the external link by default?
@minux minux changed the title SVG profile uses javascript from cyberz.org cmd/pprof: SVG profile uses javascript from cyberz.org Apr 8, 2015
@minux minux added the repo-main label Apr 8, 2015
@minux minux added this to the Go1.5 milestone Apr 8, 2015
@dr2chase
Copy link
Contributor

dr2chase commented Apr 8, 2015

I note that the referenced code has a claimed-to-be-BSD license -- source/binary use and redistribution allowed with attribution and NO-WARRANTY.

@rsc rsc removed the repo-main label Apr 14, 2015
@rsc
Copy link
Contributor

rsc commented Apr 27, 2015

The old Perl pprof (in Go 1.3) copied this code directly into the generated SVG.
The port to Go erred by trying to avoid this duplication and use a link.
The Go version of pprof will be updated to do what the Perl pprof did.

Thank you for the report.

@rsc rsc self-assigned this Apr 27, 2015
@gopherbot
Copy link

CL https://golang.org/cl/10690 mentions this issue.

@rsc rsc closed this as completed in 14da5be Jun 5, 2015
@alicebob
Copy link
Contributor Author

alicebob commented Jun 5, 2015

Looks great. Thanks!

@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
5 participants
@rsc @minux @alicebob @dr2chase @gopherbot