You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
flagSVGPan: flag.String("svgpan", "https://www.cyberz.org/projects/SVGPan/SVGPan.js", "URL for SVGPan Library"),
I found it surprising to find pprof's SVG has external dependencies. Not just because of tracking reasons (I don't think cyberz.org need to know about my pprof usage), but also because it doesn't always work (e.g. working on a train).
Would it be possible to just include the javascript code verbatim in the .SVG, or otherwise to not include the external link by default?
The text was updated successfully, but these errors were encountered:
minux
changed the title
SVG profile uses javascript from cyberz.org
cmd/pprof: SVG profile uses javascript from cyberz.org
Apr 8, 2015
The old Perl pprof (in Go 1.3) copied this code directly into the generated SVG.
The port to Go erred by trying to avoid this duplication and use a link.
The Go version of pprof will be updated to do what the Perl pprof did.
The .svg profile as generated by pprof's
web
command includes some Javascript from https://www.cyberz.org/projects/SVGPan/SVGPan.jsthe file is linked here:
go/src/cmd/pprof/internal/driver/driver.go
Line 628 in 5f84238
I found it surprising to find pprof's SVG has external dependencies. Not just because of tracking reasons (I don't think cyberz.org need to know about my pprof usage), but also because it doesn't always work (e.g. working on a train).
Would it be possible to just include the javascript code verbatim in the .SVG, or otherwise to not include the external link by default?
The text was updated successfully, but these errors were encountered: