Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: assembly failures leave zero byte file on disk #10372

Closed
davecheney opened this issue Apr 8, 2015 · 1 comment
Closed

cmd/asm: assembly failures leave zero byte file on disk #10372

davecheney opened this issue Apr 8, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@davecheney
Copy link
Contributor 

lucky(~/go/src/cmd/asm/internal/asm/testdata) % go tool asm arm.s                                                                                                         
arm.s:14: unrecognized instruction "ADD"
arm.s:15: unrecognized instruction "ADD"
arm.s:16: unrecognized instruction "ADD"
arm.s:17: unrecognized instruction "ADD"
arm.s:18: unrecognized instruction "ADD"
arm.s:19: unrecognized instruction "ADD"
arm.s:20: unrecognized instruction "ADD"
arm.s:30: unrecognized instruction "ADD"
arm.s:31: unrecognized instruction "ADD"
arm.s:32: unrecognized instruction "ADD"
arm.s:33: unrecognized instruction "ADD"
asm: too many errors
lucky(~/go/src/cmd/asm/internal/asm/testdata) % file arm.6
arm.6: empty

Assembly failures leave an empty file on disk that other tools in the build chain may interpret to be a successful completion (or throw off conditional compilation steps)
@davecheney davecheney added this to the Go1.5 milestone Apr 8, 2015
@davecheney
Copy link
Contributor Author

/cc @robpike

@robpike robpike closed this as completed in 3b1d0d0 Apr 8, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
2 participants
@davecheney @gopherbot