New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/types: std lib tests don't consider +build tags #10370
Comments
This is not super-important. Could be delayed to 1.7 or later w/o much repercussions. |
could we also consider exclude |
We already exclude files in |
I closed this prematurely. The issue is that go/types/stdlib_test.go's testTestDir function doesn't consider build tags I believe. |
Change https://golang.org/cl/144457 mentions this issue: |
Some of the std lib tests (e.g. solaris-amd64) are failing because +build tags are ignored. The tests should consider the build tags in place for the test binary (because it depends on gcimporter which sees the files as built by gc for the current platform).
The text was updated successfully, but these errors were encountered: