net: Update comment on the To4 function.
#10349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `To4` returns `nil` only if the IP address is invalid, i.e. has the wrong length.
|
Sorry, we don't accept pull requests. Please see https://golang.org/doc/contribute.html for the contribution guideline. And btw, I don't think the change is an improvement. |
|
@minux I didn't know you didn't accept pull requests (via GitHub?). Also the change is not an improvement, yes. It doesn't reduce CPU cycles or the memory requirements of |
|
The old comment says "if ip is not an IPv4 address, To4 returns nil",
which is exactly what the code does.
Your proposed change changed that sentence to
"If ip is not an IP address (it is the wrong length), To4 returns nil."
This is more confusing that it was. If the user passes in an IPv6
address (not an IPv4-mapped IPv6 address), and expect To4
to return a non-nil address. According to your docs, it should work
because the user has passed an IP address.
If you say an IPv6 address is not the "correct" length for To4, then
what about IPv4-mapped IPv6 addresses? They have the length
of IPv6 address, but To4 can still convert them to IPv4.
|
mikioh
changed the title
To4 function.To4 function.
|
Got it. Thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
To4returnsnilonly if the IP addressis invalid, i.e. has the wrong length.