Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math/big: possible problem with Float.Float32() for denormal values #10321

Closed
griesemer opened this issue Apr 2, 2015 · 3 comments
Closed

math/big: possible problem with Float.Float32() for denormal values #10321

griesemer opened this issue Apr 2, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@griesemer
Copy link
Contributor

In cmd/internal/gc/mparith3.go, function mpgetfltN, using Float32() will cause all.bash to fail in some cases. The suspicion is that there is a problem with Float.Float32() for values that end up being denormal float32's. There appear to be no explicit test cases that expose the problem for the existing mpgetfltN code which might not be correct (such test cases exist for float64 values, e.g. in the strconv library).

Investigate.
@griesemer griesemer self-assigned this Apr 2, 2015
@griesemer griesemer added this to the Go1.5 milestone Apr 2, 2015
@gopherbot
Copy link

CL https://golang.org/cl/10354 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/10350 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/10355 mentions this issue.

griesemer added a commit that referenced this issue May 22, 2015
@griesemer
cmd/compile/internal/big: update to latest version (run sh vendor.bash)
db0594b 
No manual code changes.

This will permit addressing the compiler aspect of issue #10321 in a
subsequent change.

Change-Id: I3376dc38cafa0ec98bf54de33293015d0183cc82
Reviewed-on: https://go-review.googlesource.com/10354
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
griesemer added a commit that referenced this issue May 22, 2015
@griesemer
cmd/compile/internal/gc: correctly use Float32 in mpgetfltN
bd7c1f1 
This resolves the compiler part of issue #10321.

Change-Id: I44b9909f992b37dd34b1c5292decd12de3d3a65e
Reviewed-on: https://go-review.googlesource.com/10355
Reviewed-by: Alan Donovan <adonovan@google.com>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
2 participants
@griesemer @gopherbot