-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: run a Windows XP or Server 2003 builder #10267
Comments
@bradfitz I am not sure Windows Server 2003 support is important. It is effectively Windows XP. Not many people run that OS anymore (except myself). Microsoft discontinue its support soon. Alex |
We should have a builder for anything we pretend to halfway support. If we don't support Go for Windows XP/2003, then why is #10162 still open? And the downloads page says Windows XP or above. |
Fair enough. |
@bradfitz I could host them for now. Want both a 386 and amd64 builder? I could also transfer you the ISOs and SKUs; I don't have a need for them aside from something like this now. |
I think just amd64 or just 386 is fine. Whatever is easiest. I'd prefer you just run one for now. Once I start to run one, I'd rather run it on AWS. Email me at my golang.org address and I'll get you a builder key. |
@alexbrainman, whether the vendor supports it or not is irrelevant
for this issue as we're still claiming to support XP or above.
We still haven't remove OS X 10.6 support, so we continue to have a
10.6 builder even though we've talked about removing 10.6 support.
We haven't even talked about removing XP/2003 support, and it seems
there is little reason to remove their support.
Modern windows version are using too much resources, so the only
way I can do some windows testing is on windows xp 32-bit and 2003
64-bit.
|
@minux I am not against more builders. I just don't think Windows Server 2003 is a good choice. We still don't have 386 builder (any). And even if you want something that is "very old", Windows XP 386 would me better choice. Windows XP 386 is much more common then Windows Server 2003 amd64. Just my 2c. Alex |
If you see my replies to the windows 2012 builder thread, I'm actually
in favor of setting up a real 32-bit windows builder (i.e. windows xp).
I suggest that we need a 2003 builder because it's the lowest 64-bit
windows version that we claim to support and it's more common than
64-bit windows xp.
|
I ran XP 64-bit for a long time. My understanding is XP 64-bit based off I think everyone is fine/wants a builder for amd64 and 386. I would suggest On Fri, Mar 27, 2015 at 3:09 PM Minux Ma notifications@github.com wrote:
|
WinXP 32-bit would be good too, of course. |
I've started the builder. There are currently three failures at tip: -Daniel On Sat, Mar 28, 2015 at 2:29 AM Brad Fitzpatrick notifications@github.com
|
Also runtime/pprof sometimes fails. I haven't looked into that one. On Sun, Mar 29, 2015 at 12:30 AM Daniel Theophanes kardianos@gmail.com
|
We shouldn't install a cert from another box. We need to modify the code and/or test to work on a stock Windows system without modications. As for missed ticks: first determine whether it's a VM thing. If it's just a VM thing, let's add an environment variable (IN_VM? like the IN_QEMU one we've used before) which, if enabled, skips such tests. |
This starts the process of making the coordinator about to use the buildlet on things other than GCE. Update golang/go#8647 (ARM, reverse proxy or online.net) Update golang/go#10267 (windows 2003 on AWS) Update golang/go#9495 (OS X VMWare VMs on racked Mac Minis) Change-Id: I5df79ea67e0ececba8b880e81bd93d4c80897455 Reviewed-on: https://go-review.googlesource.com/8198 Reviewed-by: David Crawshaw <crawshaw@golang.org>
I have the start of a Windows XP SP3 builder now running on VMWare. All tests passed with CGO_ENABLED=0 at tip just now. I haven't installed a C compiler yet. Thanks again to @kardianos for the help. |
/cc @johnsonj @adjackura |
I actually worked on the Windows XP builder during my leave a bit. I don't have it online yet, though. |
Change https://golang.org/cl/83055 mentions this issue: |
Updates golang/go#10267 Change-Id: I79064d9a2aca11bc14c73beef44d70098ed1ae3f Reviewed-on: https://go-review.googlesource.com/83055 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The XP SP3 builder did a few commits, but failed with:
... including after I turned off the Windows firewall. @alexbrainman, do you not also see that failure on your XP machine? /cc @mikioh |
I do see that failure on my Windows XP - I was meant to report / investigate this but I did not have time yet. This is new functionality that has been implemented in CL 76393 and related. The failure is because WSASendMsg returns WSAEINVAL, from https://msdn.microsoft.com/en-us/library/windows/desktop/ms741692(v=vs.85).aspx "The socket has not been bound with bind, or the socket was not created with the overlapped flag.". But on the bottom of that page it also says "Minimum supported client | Windows 8.1, ...". So I doubt this is designed to work on Windows XP. I propose we create an issue for it, and skip broken part of the test. Alex |
Change https://golang.org/cl/83115 mentions this issue: |
…prof tests Updates golang/go#10267 Updates golang/go#22594 Change-Id: Ib6a9e13fbaaf4aad0b74008146b55e651658d4dd Reviewed-on: https://go-review.googlesource.com/83115 Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Change https://golang.org/cl/95576 mentions this issue: |
We should run a Windows Server 2003 builder. (not just WS2008/WS2012 on GCE)
In order of difficulty:
AWS links:
http://aws.amazon.com/windows/products/ec2/server2003/ -- until July 14, 2015
http://aws.amazon.com/windows/products/ec2/server2003/access/ -- beyond July 14, 2015
/cc @alexbrainman @minux
The text was updated successfully, but these errors were encountered: