Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: android/arm is flaky #10206

Closed
crawshaw opened this issue Mar 20, 2015 · 3 comments
Closed

builder: android/arm is flaky #10206

crawshaw opened this issue Mar 20, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@crawshaw
Copy link
Member 

--- FAIL: TestPipeLookPathLeak (0.69s)
    exec_test.go:247: leaked 50 fds; want ~0; have:
        COMMAND     PID       USER   FD      TYPE             DEVICE  SIZE/OFF       NODE NAME
        init          1       root  exe       ???                ???       ???        ??? /proc/1/exe (readlink: Permission denied)
        init          1       root root       ???                ???       ???        ??? /proc/1/root (readlink: Permission denied)
        init          1       root  FDS                                                   /proc/1/fd/ (opendir: Permission denied)
        .             2       root  exe       ???                ???       ???        ??? /proc/2/exe (readlink: Permission denied)
        .             2       root root       ???                ???       ???        ??? /proc/2/root (readlink: Permission denied)
        .             2       root  FDS                                                   /proc/2/fd/ (opendir: Permission denied)
...
FAIL    os/exec 22.053s
@crawshaw crawshaw self-assigned this Mar 20, 2015
@crawshaw crawshaw added this to the Go1.5 milestone Mar 20, 2015
@crawshaw
Copy link
Member Author

Rather unsatisfactorily, I rebooted the android device. The os/exec test passes in 2.2s now (instead of 22s). It is also failing to fail on TestPipeLookPathLeak.

As the test itself includes a time.Sleep loop, I suspect the device simply became slow enough to make the test flaky.

It's not clear why the device became flaky. It was a couple of months since a reboot, but top showed no active processes and ps didn't reveal any cruft. None of the temporary directories appeared to be full.

Keeping the issue open for now just in case some evidence appears.

@crawshaw crawshaw assigned hyangah and unassigned crawshaw Mar 24, 2015
@hyangah
Copy link
Contributor

hyangah commented Mar 24, 2015

I believe this is because the lsof command on Android ignores the -p option (used to select only info on a specified pid). The test simply compares the line count of the lsof output at the beginning and end of the test and if they differ, it assumes fd leaks.

@minux
Copy link
Member

minux commented Mar 24, 2015 via email

@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned hyangah Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@minux @crawshaw @hyangah @gopherbot