Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: Warn users getting dependencies from code.google.com #10193

Closed
imjasonh opened this issue Mar 18, 2015 · 8 comments
Closed

cmd/go: Warn users getting dependencies from code.google.com #10193

imjasonh opened this issue Mar 18, 2015 · 8 comments
Milestone

Comments

@imjasonh
Copy link

Google Code is shutting down, and when it does, users who import from code.google.com will no longer have those dependencies resolve.

There are a lot of things we could try to mitigate this breakage, and it won't happen for a while, but I think it may make sense to at least print a warning to users when running go get.

@ianlancetaylor ianlancetaylor added this to the Go1.5 milestone Mar 18, 2015
@dsymonds
Copy link
Contributor

Wacky idea: Print a warning in go build (and friends) too. Lots of people have packages already checked out, so won't benefit from a go get warning alone.

@mattn
Copy link
Member

mattn commented Mar 20, 2015

If you want to check your package is depend on code.google.com, see https://github.com/mattn/check-code-google-com

@msakrejda
Copy link

What's the status here? It looks like the tool warns for some things but not others, and, e.g., oracle is just left broken on the old site:

maciek@mothra:~$ go get code.google.com/p/go.tools/cmd/oracle
# code.google.com/p/go.tools/cmd/oracle
../../../.gvm/pkgsets/go1.4/global/src/code.google.com/p/go.tools/cmd/oracle/main.go:166: too many arguments to conversion to oracle.Query: oracle.Query(args, mode, *posFlag, ptalog, &build.Default, *reflectFlag)

while godoc is nicer:

maciek@mothra:~$ go get code.google.com/p/go.tools/cmd/godoc
can't load package: the code.google.com/p/go.tools/cmd/godoc command has moved; use golang.org/x/tools/cmd/godoc instead.

Is that a server-side warning? In any case, it'd be great to provide warning; this would have saved me a few minutes tonight.

@ianlancetaylor
Copy link
Contributor

I don't think we should warn on go build. People with vendored code.google.com packages are fine as long as they don't update.

The bit about whether a package has moved is up to the package owner.

@gopherbot
Copy link

CL https://golang.org/cl/12070 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/18952 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/18974 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 27, 2016
For Go 1.7 we can remove all the code.google.com code
(except maybe the shutdown warning).

See #10193.

Change-Id: I4b8182eb66494f0bf373b40ca5da6ae4738342be
Reviewed-on: https://go-review.googlesource.com/18974
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/21189 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 28, 2016
Remove all special handling of Google Code, which has shut down.

Commit 4ec2fd3 suggested that maybe the
shutdown warning should remain. However, it has been missing from Go 1.6
already, and by Go 1.7 people will most likely have realised that Google
Code has shut down.

Updates #10193.

Change-Id: I5749bbbe2fe3b07cff4edd20303bbedaeaa8d77b
Reviewed-on: https://go-review.googlesource.com/21189
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants