Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/build: custom import path checking convention not documented #10177

Closed
rogpeppe opened this issue Mar 16, 2015 · 5 comments
Closed

go/build: custom import path checking convention not documented #10177

rogpeppe opened this issue Mar 16, 2015 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@rogpeppe
Copy link
Contributor

The Go custom import path checking convention [1, 2] does
not seem to be documented anywhere in the standard docs.

Perhaps go/build is a reasonable place to document this, being
the definitive place where the other comment-based conventions
are documented AFAIK.

[1] https://golang.org/doc/go1.4#canonicalimports
[2] https://docs.google.com/document/d/1jVFkZTcYbNLaTxXD9OcGfn7vYv5hWtPx9--lTx1gPMs
@minux
Copy link
Member

minux commented Mar 16, 2015 via email

@rogpeppe
Copy link
Contributor Author

Thanks! Perhaps it could be documented in go/build as well. What do you think?

@minux
Copy link
Member

minux commented Mar 23, 2015 via email

@rogpeppe
Copy link
Contributor Author

I would add it as part of the overview.

@rsc rsc added this to the Go1.5 milestone Apr 10, 2015
@rsc
Copy link
Contributor

rsc commented Jul 22, 2015

Import comments are really the go command's job.
go/build knows next to nothing about them, except for the ImportMode bit that Minux pointed out.
I think the docs in cmd/go are sufficient.

@rsc rsc closed this as completed Jul 22, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@rogpeppe @rsc @minux @gopherbot