x/sys/unix, windows: needs to track update to syscall #10150

robpike · 2015-03-12T22:35:34Z

Since 1.4, my hand scan of the changes to the core repo's syscall package yields these CLs, many of which need to be applied to the go.sys repo:

This is not a perfect list. Some may be missing and some are internal/syscall and might not apply.

These CLs (and whatever follow, which should be added to this bug) need to be examined and, if appropriated, adapted and applied to go.sys.

More fundamentally, we also need to stop these packages from diverging so much in future. Some process may be required to encourage updating.

From a higher perspective, I am surprised at the amount of churn in a supposedly quiet package.

robpike · 2015-03-12T22:40:17Z

cc @davecheney @adg

alexbrainman · 2015-03-12T23:29:25Z

I looked at windows related syscall package changes only. I can see 3.

syscall: use go generate to build zsyscall_windows.go
https://go-review.googlesource.com/#/c/1940/

I have (had for a while ready for review) correspondent go.sys change
windows: use go generate to build zsyscall_windows.go
https://go-review.googlesource.com/#/c/2530/
If someone wants to review it, go ahead.

syscall: Readlink doesn't handle junction on windows
https://go-review.googlesource.com/#/c/2307/

I dropped ball with this change. I will take care of it.

syscall: make mksyscall_windows.go to work even when output does not uses unsafe
https://go-review.googlesource.com/#/c/5005/

This change does not need to be copied to go.sys. Only z*.go go.sys files needs to be re-generated. That has already happened in unrelated go.sys change.

Alex

mikioh · 2015-03-13T03:33:18Z

I would propose to remove networking-related stuff from sys/unix; specifically the following:

Subset of routing message parsers for BSD variants
Subset of netlink message parsers for Linux
BPF (Berkeley Packet Filter) for BSD variants
LSF (Linux Socket Filter) for Linux

Simply net sub repository seems to be right place for them. Thoughts?

robpike · 2015-03-13T13:43:23Z

Mikioh: I don't know enough about networking to guarantee whether this is OK, but that sounds reasonable to me.

Alex: 2530 LGTM. Thanks.

robpike · 2015-03-14T00:43:56Z

~~https://go-review.googlesource.com/#/c/6555/~~

robpike · 2015-03-15T14:25:04Z

https://go-review.googlesource.com/#/c/4913/ also needs to be applied

robpike · 2015-03-15T14:27:03Z

https://go-review.googlesource.com/7543 also needs to be applied

Those libraries, routing message parsers, netlink message parsers, berkeley packat filter are linux packet filter, are subsets and just for the net package of standard library. It would be better keeping, extending them at the net sub repository instead of here. Updates golang/go#10150. Change-Id: I1ca437bea2e2be7f7f8f6496d4db291629f49136 Reviewed-on: https://go-review.googlesource.com/7581 Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Rob Pike <r@golang.org>

4ad · 2015-03-24T19:44:25Z

https://go-review.googlesource.com/8022/ also needs to be applied.

Some Linux architectures (e.g. arm64) don't have the getpgrp syscall, use getpgid(0) to emulate it. Update golang/go#10150. This brings CL 8022 that has been applied to the syscall package to x/sys. Change-Id: I24c6d7e8b5b2f075ca4e68b142b2e03ab8a43342 Signed-off-by: Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/8023 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

robpike · 2015-03-24T20:37:10Z

https://go-review.googlesource.com/8022 has been applied to x/sys by https://go-review.googlesource.com/8023

robpike · 2015-03-26T22:08:21Z

https://go-review.googlesource.com/7940
https://go-review.googlesource.com/6701

robpike · 2015-04-09T20:29:25Z

https://go-review.googlesource.com/#/c/2167

robpike · 2015-04-09T23:13:12Z

https://go-review.googlesource.com/#/c/8721/ handles 6350 and 6385

robpike · 2015-04-09T23:14:27Z

https://go-review.googlesource.com/#/c/8720/ handles 2167

Related issue golang/go#10150 Change-Id: I38e3e13238624655bb828d501bc865ff8a4312e9 Reviewed-on: https://go-review.googlesource.com/7493 Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

robpike · 2015-05-13T21:37:50Z

http://golang.org/cl/5833
http://golang.org/cl/5835
http://golang.org/cl/5837

are done by https://go-review.googlesource.com/10032

bradfitz · 2015-05-13T21:38:45Z

This style of bug is hard to follow or close.

N smaller, closable bugs might be better.

robpike · 2015-05-13T22:05:08Z

I like having it in one.

http://golang.org/cl/8723
fixed by
https://go-review.googlesource.com/10035

4ad · 2015-05-13T22:05:40Z

Perhaps a milestone? Whatever github has to group issues.

This is a copy of http://golang.org/cl/9870 in the syscall package. This is in preparation for arm64 support, as the arm64 Linux kernel does not have an inotify_init system call, only inotify_init1. Update golang/go#10150. Change-Id: I9224a094af79adbb2f5714ad977b195d5a941eb0 Reviewed-on: https://go-review.googlesource.com/10036 Reviewed-by: Rob Pike <r@golang.org>

robpike · 2015-05-13T22:17:21Z

https://golang.org/cl/9870/
fixed by
https://go-review.googlesource.com/#/c/10036/

I will create a new bug with only the remaining ones, since people seem offended by this particular noise source when there is so much other noise out there.

robpike added this to the Go1.5 milestone Mar 12, 2015

robpike self-assigned this Mar 12, 2015

mikioh added the repo-sys label Mar 13, 2015

mikioh changed the title ~~go.sys: needs to track update to syscall~~ unix, windows: needs to track update to syscall Mar 14, 2015

bradfitz mentioned this issue Mar 27, 2015

x/sys: apply errno amortization CL #10266

Closed

rsc changed the title ~~unix, windows: needs to track update to syscall~~ x/sys/unix, windows: needs to track update to syscall Apr 14, 2015

rsc modified the milestones: Unreleased, Go1.5 Apr 14, 2015

rsc removed the repo-sys label Apr 14, 2015

robpike closed this as completed May 13, 2015

golang locked and limited conversation to collaborators Jun 25, 2016

gopherbot added the FrozenDueToAge label Jun 25, 2016

rsc unassigned robpike Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/sys/unix, windows: needs to track update to syscall #10150

x/sys/unix, windows: needs to track update to syscall #10150

robpike commented Mar 12, 2015

robpike commented Mar 12, 2015

alexbrainman commented Mar 12, 2015

mikioh commented Mar 13, 2015

robpike commented Mar 13, 2015

robpike commented Mar 14, 2015

robpike commented Mar 15, 2015

robpike commented Mar 15, 2015

4ad commented Mar 24, 2015

robpike commented Mar 24, 2015

robpike commented Mar 26, 2015

robpike commented Apr 9, 2015

robpike commented Apr 9, 2015

robpike commented Apr 9, 2015

robpike commented May 13, 2015

bradfitz commented May 13, 2015

robpike commented May 13, 2015

4ad commented May 13, 2015

robpike commented May 13, 2015

x/sys/unix, windows: needs to track update to syscall #10150

x/sys/unix, windows: needs to track update to syscall #10150

Comments

robpike commented Mar 12, 2015

robpike commented Mar 12, 2015

alexbrainman commented Mar 12, 2015

mikioh commented Mar 13, 2015

robpike commented Mar 13, 2015

robpike commented Mar 14, 2015

robpike commented Mar 15, 2015

robpike commented Mar 15, 2015

4ad commented Mar 24, 2015

robpike commented Mar 24, 2015

robpike commented Mar 26, 2015

robpike commented Apr 9, 2015

robpike commented Apr 9, 2015

robpike commented Apr 9, 2015

robpike commented May 13, 2015

bradfitz commented May 13, 2015

robpike commented May 13, 2015

4ad commented May 13, 2015

robpike commented May 13, 2015