Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: make get send fallback http request earlier than the 30s it takes for https to time out #10120

Closed
cespare opened this issue Mar 9, 2015 · 4 comments
Closed

cmd/go: make get send fallback http request earlier than the 30s it takes for https to time out #10120

cespare opened this issue Mar 9, 2015 · 4 comments
Labels
FrozenDueToAge

Comments

@cespare
Copy link
Contributor

cespare commented Mar 9, 2015

Right now go get makes a meta tag request using https first; if this hangs forever, the request times out after 30 seconds before trying the http fallback.

This means that a package served from a vanity domain where https requests are dropped can take a long time to install. See this golang-nuts thread for more context:

https://groups.google.com/d/msg/golang-nuts/ixF0h1YYCoQ/9wfBu4deaM0J

@dsymonds suggests that go get could kick off the http fallback request after 5s instead of waiting for the full 30s timeout.
@adg
Copy link
Contributor

adg commented Mar 9, 2015

Related to #9637

@rsc
Copy link
Contributor

rsc commented Apr 10, 2015

It will be https only in Go 1.5, so this is obsolete.

@rsc rsc closed this as completed Apr 10, 2015
@cespare cespare mentioned this issue Apr 10, 2015
Closed
@gopherbot
Copy link

CL https://golang.org/cl/7181 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/9715 mentions this issue.

adg added a commit that referenced this issue Jun 24, 2015
@adg
cmd/go: don't fetch from insecure repositories without -insecure
5bf1853 
Fixes #9637
Fixes #10120

Change-Id: I3728239089efb94d04cd4115c9f840afd7badeaf
Reviewed-on: https://go-review.googlesource.com/9715
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rsc @cespare @adg @gopherbot