Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: can't update CL #10115

Closed
4ad opened this issue Mar 8, 2015 · 5 comments
Closed

x/review/git-codereview: can't update CL #10115

4ad opened this issue Mar 8, 2015 · 5 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@4ad
Copy link
Member

4ad commented Mar 8, 2015 

: iridium:objdump; git10
deaff58 cmd/objdump: disable TestDisasm.* on arm64 (Aram Hăvărneanu)
83de6fb os/signal, hash/crc32: add arm64 build tags (Aram Hăvărneanu)
5062413 test: fix nosplit test, and disable nilptr3 test on arm64 (Aram Hăvărneanu)
a1c7606 reflect: add support for GOARCH=arm64 (Aram Hăvărneanu)
7acac93 sync/atomic: add support for GOARCH=arm64 (Aram Hăvărneanu)
aebe012 math, math/big: add support for GOARCH=arm64 (Aram Hăvărneanu)
4430bdf syscall: add support for GOARCH=arm64 (Aram Hăvărneanu)
aaf583c runtime: add support for GOARCH=arm64 (Aram Hăvărneanu)
16a950a cmd/dist: add suport for GOARCH=arm64 (Aram Hăvărneanu)
b974414 cmd/cgo: add support for GOARCH=arm64 (Aram Hăvărneanu)
: iridium:objdump; git mail deaff58
[...]          
remote: (W) No changes between prior commit ffcc30e and new commit 4430bdf        
To https://go.googlesource.com/go
 ! [remote rejected] HEAD -> refs/for/master (no changes made)
error: failed to push some refs to 'https://go.googlesource.com/go'
(running: git push -q origin HEAD:refs/for/master)
git-codereview: exit status 1
: iridium:objdump;

Except that the error message is not true, the current code is not the one in gerrit. Gerrit CL is stale and I can't update.
@minux
Copy link
Member

minux commented Mar 8, 2015 via email

@4ad
Copy link
Member Author

4ad commented Mar 8, 2015

Yes, I tried to bypass it, same error.

iridium:go$ git push origin HEAD:refs/for/master
Counting objects: 71, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (23/23), done.
Writing objects: 100% (23/23), 2.76 KiB | 0 bytes/s, done.
Total 23 (delta 15), reused 0 (delta 0)
remote: Resolving deltas: 100% (15/15)
remote: Processing changes: refs: 1, done    
remote: (W) No changes between prior commit ffcc30e and new commit 4430bdf
To https://go.googlesource.com/go
 ! [remote rejected] HEAD -> refs/for/master (no changes made)
error: failed to push some refs to 'https://go.googlesource.com/go'
iridium:go$

@minux
Copy link
Member

minux commented Mar 8, 2015 via email

@4ad
Copy link
Member Author

4ad commented Mar 8, 2015

https://github.com/4ad/go/tree/merge.arm64

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title git-codereview: can't update CL x/review/git-codereview: can't update CL Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@ysmolski ysmolski added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 6, 2018
@ysmolski
Copy link
Member

ysmolski commented Nov 6, 2018

That branch is not accessible anymore. Thus it cannot be reproduced anymore. @4ad feel free to reopen if this is still relevant for you.

@ysmolski ysmolski closed this as completed Nov 6, 2018
@golang golang locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@rsc @minux @ysmolski @4ad @gopherbot