Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/arm64: moves that use C_BITCON and C_ADDCON don't work #10111

Open
4ad opened this issue Mar 8, 2015 · 3 comments
Open

cmd/internal/obj/arm64: moves that use C_BITCON and C_ADDCON don't work #10111

4ad opened this issue Mar 8, 2015 · 3 comments
Milestone
Unplanned

Comments

@4ad
Copy link
Member

4ad commented Mar 8, 2015

Replaces 4ad/go#68.

Issue #10108 is related.
@4ad 4ad added this to the Go1.5Maybe milestone Mar 8, 2015
@4ad 4ad self-assigned this Mar 8, 2015
@4ad 4ad added the arch-arm64 label Mar 8, 2015
@rsc rsc removed the arch-arm64 label Apr 10, 2015
@rsc
Copy link
Contributor

rsc commented Jun 29, 2015

Too late for Go 1.5.

@rsc rsc modified the milestones: Unplanned, Go1.5Maybe Jun 29, 2015
@mwhudson mwhudson mentioned this issue Oct 5, 2015
Closed
mwhudson added a commit to mwhudson/go that referenced this issue Oct 5, 2015
@mwhudson
cmd/compile, cmd/internal/obj/arm64: handle bitmask immediates for 64…
b622eaa 
…-bit operations

DO NOT SUBMIT

(I need to write a lot more here)

Updates golang#10111

Change-Id: I5bf6a5bb14ace3a5852288551566be20dd4e0b17
@mwhudson
Copy link
Contributor

mwhudson commented Oct 5, 2015

https://github.com/mwhudson/go/tree/bimm has some stuff I wrote around this (it calculates the acceptable bimm values at runtime). For reference, there is a lot of discussion about this in https://go-review.googlesource.com/#/c/7046/

@mwhudson mwhudson mentioned this issue Jul 1, 2016
Closed
@zhangfannie
Copy link
Contributor

@4ad Do you mean C_BITCON class and C_ADDCON class constants can not be encoded as MOVs instructions? If yes, I find current assembler can encode C_BITCON as MOVs instructions, but can not encode C_ADDCON as MOVs instructions. I submitted a CL https://go-review.googlesource.com/c/go/+/120661 that encodes C_BITCON as MOVs instructions. I am not sure if the CL fixes this issue you found? Could you mind have a review this CL? Thank you.

@rsc rsc unassigned 4ad Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@rsc @mwhudson @4ad @zhangfannie