Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/arm64: add frame pointers #10110

Closed
4ad opened this issue Mar 8, 2015 · 6 comments
Closed

cmd/internal/obj/arm64: add frame pointers #10110

4ad opened this issue Mar 8, 2015 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@4ad
Copy link
Member

4ad commented Mar 8, 2015

RISC architectures fare much worse in gdb compared to x86. Right now we can't have stack traces in gdb, on arm64. Adding frame pointers would fix this.
@4ad 4ad self-assigned this Mar 8, 2015
@4ad 4ad added this to the Go1.5Maybe milestone Mar 8, 2015
@4ad
Copy link
Member Author

4ad commented Mar 8, 2015

Replaces 4ad/go#101

@minux
Copy link
Member

minux commented Mar 8, 2015 via email

@4ad 4ad added the arch-arm64 label Mar 8, 2015
@minux minux mentioned this issue Apr 4, 2015
Closed
@rsc rsc removed the arch-arm64 label Apr 10, 2015
@rsc
Copy link
Contributor

rsc commented Jun 29, 2015

Too late for Go 1.5.

@rsc rsc modified the milestones: Unplanned, Go1.5Maybe Jun 29, 2015
@zhongweiy
Copy link
Contributor

https://go-review.googlesource.com/#/c/20193/ fixes backtrace in gdb under arm64. And it turns out that the break backtrace is caused by incorrect handling ra position relative to CFA during function call in DWARF '.debug_frame' under arm64.

I find frame pointer is still needed in linux perf tool to unwind stack when using "--call-graph fp". But it could be workarounded by telling perf unwind stack using DWARF info.

@4ad
Copy link
Member Author

4ad commented Jun 3, 2016

Yes, we we add frame pointers in 1.8.

@eliasnaur eliasnaur mentioned this issue Aug 30, 2017
Closed
@gopherbot
Copy link

Change https://golang.org/cl/61511 mentions this issue: build: support frame-pointer for arm64

@bradfitz bradfitz modified the milestones: Unplanned, Go1.11 Dec 4, 2017
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 30, 2018
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 30, 2018
@golang golang locked and limited conversation to collaborators Aug 29, 2019
@rsc rsc unassigned 4ad Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
7 participants
@bradfitz @rsc @minux @4ad @zhongweiy @ianlancetaylor @gopherbot