Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/cmd/builder: don't rely on fast-forwards for updating local git repo #10085

Closed
adg opened this issue Mar 5, 2015 · 1 comment
Closed

build/cmd/builder: don't rely on fast-forwards for updating local git repo #10085

adg opened this issue Mar 5, 2015 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@adg
Copy link
Contributor

adg commented Mar 5, 2015

The builder does a "git pull" to update its local copy of the go repo, but that might fail if the repo is force-pushed to fix a bad merge (as happened recently).

Instead it should do something like git fetch && git reset --hard origin/master.

cc @bradfitz
@adg adg self-assigned this Mar 5, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@bradfitz
Copy link
Contributor

bradfitz commented Feb 2, 2017

Mostly irrelevant these days. Almost all builders use the new-style builder which doesn't run "git" at all.

But still applies to people who run the old builders.

@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Feb 2, 2017
@bradfitz bradfitz modified the milestones: Unreleased, Unplanned Feb 2, 2017
@adg adg closed this as completed Feb 14, 2018
@golang golang locked and limited conversation to collaborators Feb 14, 2019
@rsc rsc unassigned adg Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @rsc @adg @gopherbot