You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow up to change https://go-review.googlesource.com/#/c/3967
The change moves freedefer from goroutine stack to system stack, because otherwise nosplit stack overflows with -N as:
runtime.cgocallbackg: nosplit stack overflow
504 assumed on entry to runtime.cgocallbackg
456 after runtime.cgocallbackg uses 48
448 on entry to runtime.cgocallbackg1
512 after runtime.cgocallbackg1 uses -64
504 on entry to runtime.deferreturn
408 after runtime.deferreturn uses 96
400 on entry to runtime.freedefer
64 after runtime.freedefer uses 336
56 on entry to runtime.writebarrierptr
32 after runtime.writebarrierptr uses 24
24 on entry to runtime.writebarrierptr_shadow
-16 after runtime.writebarrierptr_shadow uses 40
newdefer is already on system stack.
For performance reasons we would like to move fast paths of both newdefer and freedefer to goroutine stack.
This is a follow up to change https://go-review.googlesource.com/#/c/3967
The change moves freedefer from goroutine stack to system stack, because otherwise nosplit stack overflows with -N as:
runtime.cgocallbackg: nosplit stack overflow
504 assumed on entry to runtime.cgocallbackg
456 after runtime.cgocallbackg uses 48
448 on entry to runtime.cgocallbackg1
512 after runtime.cgocallbackg1 uses -64
504 on entry to runtime.deferreturn
408 after runtime.deferreturn uses 96
400 on entry to runtime.freedefer
64 after runtime.freedefer uses 336
56 on entry to runtime.writebarrierptr
32 after runtime.writebarrierptr uses 24
24 on entry to runtime.writebarrierptr_shadow
-16 after runtime.writebarrierptr_shadow uses 40
newdefer is already on system stack.
For performance reasons we would like to move fast paths of both newdefer and freedefer to goroutine stack.
@randall77
The text was updated successfully, but these errors were encountered: