code review 99680044: runtime: fix error check in freebsd/386 i386_set_ldt

runtime: fix error check in freebsd/386 i386_set_ldt

Update issue 2675

The code here was using the error check for Linux/386,
not the one for FreeBSD/386. Most of the time it worked.

Thanks to Neel Natu (FreeBSD developer) for finding this.

The s/JCC/JAE/ a few lines later is a no-op but makes the
test match the rest of the file. Why we write JAE instead of JCC
I don't know, but the two are equivalent and the file might
as well be consistent.

[rsc, 2014-05-31 01:32:03]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-05-31 01:47:06]

LGTM in that it's already had two reviews if Neel pointed it out



On Fri, May 30, 2014 at 6:32 PM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: fix error check in freebsd/386 i386_set_ldt
>
> Update issue 2675
>
> The code here was using the error check for Linux/386,
> not the one for FreeBSD/386. Most of the time it worked.
>
> Thanks to Neel Natu (FreeBSD developer) for finding this.
>
> The s/JCC/JAE/ a few lines later is a no-op but makes the
> test match the rest of the file. Why we write JAE instead of JCC
> I don't know, but they two are equivalent and the file might
> as well be consistent.
>
> Please review this at https://codereview.appspot.com/99680044/
>
> Affected files (+2, -3 lines):
>   M src/pkg/runtime/sys_freebsd_386.s
>
>
> Index: src/pkg/runtime/sys_freebsd_386.s
> ===================================================================
> --- a/src/pkg/runtime/sys_freebsd_386.s
> +++ b/src/pkg/runtime/sys_freebsd_386.s
> @@ -309,8 +309,7 @@
>         MOVL    AX, 8(SP)
>         MOVL    $165, AX
>         INT     $0x80
> -       CMPL    AX, $0xfffff001
> -       JLS     2(PC)
> +       JAE     2(PC)
>         INT     $3
>         RET
>
> @@ -326,7 +325,7 @@
>         MOVSL                           // arg 6 - newlen
>         MOVL    $202, AX                // sys___sysctl
>         INT     $0x80
> -       JCC     3(PC)
> +       JAE     3(PC)
>         NEGL    AX
>         RET
>         MOVL    $0, AX
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[minux, 2014-05-31 01:56:20]

LGTM.

[rsc, 2014-05-31 13:35:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=ced50cea54db ***

runtime: fix error check in freebsd/386 i386_set_ldt

Update issue 2675

The code here was using the error check for Linux/386,
not the one for FreeBSD/386. Most of the time it worked.

Thanks to Neel Natu (FreeBSD developer) for finding this.

The s/JCC/JAE/ a few lines later is a no-op but makes the
test match the rest of the file. Why we write JAE instead of JCC
I don't know, but the two are equivalent and the file might
as well be consistent.

LGTM=bradfitz, minux
R=golang-codereviews, bradfitz, minux
CC=golang-codereviews
https://codereview.appspot.com/99680044

[gobot, 2014-05-31 14:18:28]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/59bcff8391af0e1ee0bf72a074b75830d97b73ec