code review 9955043: testing: fix a goroutine leak in threadRing stresstest

testing: fix a goroutine leak in threadRing stresstest

Fixes issue 5527.

[robryk, 2013-06-03 01:51:20]

After running

GOMAXPROCS=2 ./stress -exec=false -maps=false -net=false -parsego=false

for half an hour, the virtual memory allocation was constant at about 400M and
there were 79 goroutines alive.

[robryk, 2013-06-03 01:51:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dvyukov, 2013-06-03 04:48:18]

LGTM

[bradfitz, 2013-06-03 14:07:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=bc2993c5834f ***

test/stress: fix a goroutine leak in threadRing stresstest

Fixes issue 5527

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/9955043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[dfc, 2013-06-05 03:35:58]

Any chance of getting this merged to the 1.1 branch?



On 04/06/2013, at 0:07, bradfitz@golang.org wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=bc2993c5834f ***
> 
> test/stress: fix a goroutine leak in threadRing stresstest
> 
> Fixes issue 5527
> 
> R=golang-dev, dvyukov
> CC=golang-dev
> https://codereview.appspot.com/9955043
> 
> Committer: Brad Fitzpatrick <bradfitz@golang.org>
> 
> 
> https://codereview.appspot.com/9955043/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[r, 2013-06-05 03:40:14]

A leak in a test doesn't seem like a critical fix to me. We'd like to
keep the changes to the branch to a minimum.

-rob

[dfc, 2013-06-05 03:44:09]

Not a problem, I'll patch this in manually when testing the branch. 



On 05/06/2013, at 13:39, Rob Pike <r@golang.org> wrote:

> A leak in a test doesn't seem like a critical fix to me. We'd like to
> keep the changes to the branch to a minimum.
> 
> -rob